-
Notifications
You must be signed in to change notification settings - Fork 211
feat(volo): introduce shmipc as transport layer protocol #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (5.12%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 43.44% 43.28% -0.16%
==========================================
Files 160 160
Lines 19383 19439 +56
==========================================
- Hits 8421 8415 -6
- Misses 10962 11024 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9e870b7 to
ae235f1
Compare
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
f8c2500 to
029d88b
Compare
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Motivation
Introduce shmipc as transport layer protocol
Note
Introduces ShmIPC as an optional transport and updates the networking stack to support it, along with a new async IO extension trait.
net::shmipc(address, config, conn, helpers) and feature-gates it behindfeatures = ["shmipc"]net::Address,ConnStream,OwnedReadHalf/OwnedWriteHalf,DefaultIncoming, and dialing to handleShmipcendpoints/streams; TLS explicitly rejectsShmipcnet::ready::AsyncReadywithnet::ext::AsyncExt; updatesBufReaderand thrift default codec bounds to useAsyncExtshmipcfeature where applicable; add--no-shmipcflag for macOS/Windows runs; add coverage jobshmipcandarc-swapdeps and wire feature involoand workspaceWritten by Cursor Bugbot for commit 029d88b. This will update automatically on new commits. Configure here.