Skip to content

Conversation

@yukiiiteru
Copy link
Member

@yukiiiteru yukiiiteru commented Jan 23, 2026

Motivation

Introduce shmipc as transport layer protocol


Note

Introduces ShmIPC as an optional transport and updates the networking stack to support it, along with a new async IO extension trait.

  • Adds net::shmipc (address, config, conn, helpers) and feature-gates it behind features = ["shmipc"]
  • Extends net::Address, ConnStream, OwnedReadHalf/OwnedWriteHalf, DefaultIncoming, and dialing to handle Shmipc endpoints/streams; TLS explicitly rejects Shmipc
  • Replaces net::ready::AsyncReady with net::ext::AsyncExt; updates BufReader and thrift default codec bounds to use AsyncExt
  • HTTP/GRPC client code paths add catch-all for unsupported address variants
  • CI: run clippy with shmipc feature where applicable; add --no-shmipc flag for macOS/Windows runs; add coverage job
  • Cargo: add shmipc and arc-swap deps and wire feature in volo and workspace

Written by Cursor Bugbot for commit 029d88b. This will update automatically on new commits. Configure here.

@yukiiiteru yukiiiteru requested review from a team as code owners January 23, 2026 06:17
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 5.12821% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.28%. Comparing base (5fdef10) to head (029d88b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
volo/src/net/ext.rs 0.00% 27 Missing ⚠️
volo/src/net/conn.rs 0.00% 25 Missing ⚠️
volo/src/net/mod.rs 7.69% 12 Missing ⚠️
volo/src/net/dial.rs 0.00% 6 Missing ⚠️
volo-grpc/src/transport/client.rs 0.00% 1 Missing ⚠️
volo-http/src/client/target.rs 0.00% 1 Missing ⚠️
volo-http/src/error/client.rs 0.00% 1 Missing ⚠️
volo-http/src/server/utils/client_ip.rs 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (5.12%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   43.44%   43.28%   -0.16%     
==========================================
  Files         160      160              
  Lines       19383    19439      +56     
==========================================
- Hits         8421     8415       -6     
- Misses      10962    11024      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
@PureWhiteWu
Copy link
Member

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@yukiiiteru yukiiiteru merged commit e6ecfa0 into cloudwego:main Jan 23, 2026
12 of 15 checks passed
@yukiiiteru yukiiiteru deleted the feat/shmipc-volo branch January 23, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants