Merged
Conversation
Owner
|
有几个改进建议:
set_imge_rect { width = 100, height = 100, color = 0xffffff } 这些项目就可以实现好默认值,这样也能在后面再扩展做兼容。
https://github.com/cloudwu/soluna/blob/master/src/render.c#L491 |
cloudwu
reviewed
Feb 8, 2026
Owner
|
7c05807 我在这里给 sampler 加上了 filter 和 wrap 的参数。还有一些以后根据需要再加。 在 setting 文件中,加入 就可以设置 不过。就这里的 shader 而言,设置 nearest 采样是没有意义的。因为这个贴图是 sdf 图,它在生成时就有过渡了。如果需要做点阵字,从生成贴图环节就不能生成 sdf 图,且需要写一个额外的 text shader ,这样 nearest 采样才有意义。 |
b791985 to
78e0df6
Compare
cloudwu
reviewed
Feb 8, 2026
78e0df6 to
18130cd
Compare
Contributor
Author
这里是打算使用 linear, 似乎默认是 nearest. |
cloudwu
reviewed
Feb 8, 2026
cb0692d to
5cb8e44
Compare
cloudwu
reviewed
Feb 8, 2026
5cb8e44 to
42b31fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.