exit with code 0 #17
Merged
exit with code 0 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarini
requested changes
Jun 30, 2020
CHANGELOG.md
Outdated
| - Datasets layout on space page would sometimes have overlapping tiles. | ||
|
|
||
| ### Changed | ||
| - init script with users would return with exit code -1 if user exists, now returns exit code 0 |
Member
There was a problem hiding this comment.
can you change to mongo-init for clarity?
lmarini
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mongo init script would return with exit code -1 if the user already exists. Now it will return with exit code 0. This will allow scripts to continue. This is used in the init-container for kubernetes.
Review Time Estimate
Types of changes
Checklist: