438 browser back on 403 page takes us to the dataset page we dont have access to #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunapa
force-pushed
the
438-browser-back-on-403-page-takes-us-to-the-dataset-page-we-dont-have-access-to
branch
from
d0d2562 to
f6056a5
Compare
Contributor
|
Here is what I see currently happening. I get an error pop up, and back takes me to explore. Is Screen.Recording.2023-05-11.at.1.56.40.PM.movthis what should be happening? |
tcnichol
approved these changes
May 18, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
After meeting we agree that what we see is intended behavior, marking approved.
…-dataset-page-we-dont-have-access-to
max-zilla
deleted the
438-browser-back-on-403-page-takes-us-to-the-dataset-page-we-dont-have-access-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-05-03.at.7.01.22.PM.mov