-
Notifications
You must be signed in to change notification settings - Fork 6
200 fix hardcoding pieces in helm chart #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
robkooper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will hard-code the realm to be for a specific instance, and will overwrite the changes that the user makes on a restart of keycloak.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a massive file, and not sure all the parameters are needed if they are the defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a mini version of that but i haven't test it
Ah right... what's a better way then, using initContainers? |
|
I would have it as an optional hook (post-install) in the helm chart when you install it (not upgrade). I would have a boolean flag that is "install realm" and have it be false. This way the user can decide that you want to import it. Problem with init is that if you are not careful it will overwrite any changes the user has made. |
|
I would check to see how you can make it such that you can use some template variables and have the host for ingress be injected in the json document for the realm, as well as minimize it as much as possible. |
|
Created a new task for it #689 for the future. |
Load the keycloak realm in as ConfigMap. You can test by deleting the Realm in keycloak and then restart the keycloak pods see if it gets loaded correctly.