Skip to content

Conversation

@longshuicy
Copy link
Member

Load the keycloak realm in as ConfigMap. You can test by deleting the Realm in keycloak and then restart the keycloak pods see if it gets loaded correctly.

@longshuicy longshuicy requested a review from robkooper August 25, 2023 15:33
@longshuicy longshuicy requested a review from lmarini as a code owner August 25, 2023 15:33
@longshuicy longshuicy linked an issue Aug 25, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will hard-code the realm to be for a specific instance, and will overwrite the changes that the user makes on a restart of keycloak.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive file, and not sure all the parameters are needed if they are the defaults.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a mini version of that but i haven't test it

@longshuicy
Copy link
Member Author

This will hard-code the realm to be for a specific instance, and will overwrite the changes that the user makes on a restart of keycloak.

Ah right... what's a better way then, using initContainers?

@robkooper
Copy link
Member

I would have it as an optional hook (post-install) in the helm chart when you install it (not upgrade). I would have a boolean flag that is "install realm" and have it be false. This way the user can decide that you want to import it.

Problem with init is that if you are not careful it will overwrite any changes the user has made.

@robkooper
Copy link
Member

I would check to see how you can make it such that you can use some template variables and have the host for ingress be injected in the json document for the realm, as well as minimize it as much as possible.

@longshuicy
Copy link
Member Author

Created a new task for it #689 for the future.

@lmarini lmarini merged commit 661c5a6 into main Aug 31, 2023
@lmarini lmarini deleted the 200-fix-hardcoding-pieces-in-helm-chart branch August 31, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix hardcoding pieces in helm chart

4 participants