671 file breadcrumbs in the wrong spot #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
is it intended that for file it shows at the top, but for folder it shows under the tabs? |
Contributor
Author
|
@longshuicy that was what Luigi wanted, but @lmarini can you check this just to be sure? I also think that changing from button to link removed any white space before the folder name. |
Contributor
Author
|
I have a few more changes to make here so I changed this to draft. |
longshuicy
approved these changes
Sep 6, 2023
…g-spot' into 671-file-breadcrumbs-in-the-wrong-spot # Conflicts: # frontend/src/components/files/File.tsx
lmarini
approved these changes
Sep 6, 2023
ddey2
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is fixed. Luigi, let me know if this looks right.