Adding a card for no content #724
Conversation
Somehow it's rendering it 6times. I am looking into why/where this piece of code is getting called.
|
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Functionality works. We might want to improve the visual in a subsequent task?
|
Updated the ui. I think for now this should be good. We can alter it later if needed. |
|
Generally works as expected. However, if image files are small enough to use raw bytes but there is no viz config, it still shows the error message along with the raw preview which might be confusing: I think we should only show this message if we can't do anything with the raw bytes. Not sure how easy that is to determine right now though (i.e. would we have to check MIME types and stuff?) |
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Like we discussed on Thursday, you might need to add similar logic in the useEffect.
max-zilla
left a comment
max-zilla
left a comment
There was a problem hiding this comment.
Correctly shows when file is too big for bytes preview, when no viz config is available otherwise, and does not show either if a byte preview is shown. behaves as expected
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Tested a few scenarios. Works and approve.
No description provided.