Skip to content

Fix bugs related to group #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-zilla merged 6 commits into from
Sep 14, 2023
Merged

Fix bugs related to group #726

max-zilla merged 6 commits into from
Sep 14, 2023

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Sep 12, 2023 •
edited
Loading

  1. fix the margin between "add member" button and "edit"
  2. delete group works now
  3. alignment of the overall group table

@longshuicy longshuicy linked an issue Sep 12, 2023 that may be closed by this pull request
Edit group bugs #704
Closed
@longshuicy longshuicy requested review from arunapa, ddey2, lmarini, max-zilla and tcnichol and removed request for arunapa September 12, 2023 16:27
@longshuicy longshuicy marked this pull request as draft September 12, 2023 16:27
@longshuicy longshuicy changed the title add margin Fix bugs related to group Sep 12, 2023
@longshuicy longshuicy marked this pull request as ready for review September 12, 2023 19:30
ddey2
ddey2 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@max-zilla max-zilla merged commit b61d8d5 into main Sep 14, 2023
@max-zilla max-zilla deleted the 704-edit-group-bugs branch September 14, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-zilla max-zilla max-zilla approved these changes

@ddey2 ddey2 ddey2 approved these changes

@tcnichol tcnichol Awaiting requested review from tcnichol

@lmarini lmarini Awaiting requested review from lmarini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit group bugs

4 participants

@longshuicy @max-zilla @ddey2