735 sharing tab bugs #736
Merged
735 sharing tab bugs #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'allow' should not be sent in to remove dataset role, it is the wrong boolean
fixing the user role update the same way. elasticsearch needed to be passed in before other arguments, indexing was failing.
Closed
this would catch similar bugs in the future
Contributor
Author
|
I added some new tests for sharing a dataset with a user and changing the role, and sharing the dataset with a group and changing the role. They should catch similar bugs in the future. |
ddey2
approved these changes
Sep 18, 2023
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
works. Thanks for adding the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix both sharing tab bugs.
The error for both changing the user role and the group role were that the wrong arguments were getting passed to the remove_dataset_user_role and remove_dataset_group_role methods. That was causing indexing on elasticsearch to fail. Now both should be fixed.