702 thumbnail bytes sometimes doesnt show with 404 #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Testing, I am not getting the 404 with any .png images, also tested with .jpg. I can mark this one approved. |
tcnichol
approved these changes
Sep 20, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Tested with png and jpg files, looks like the error is not happening anymore.
ddey2
approved these changes
Sep 21, 2023
max-zilla
deleted the
702-thumbnail-bytes-sometimes-doesnt-show-with-404
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like that I need to store the cookie at the "root" directorate so files on the path can access it.
Can't seem to trigger 404 anymore with this change; and I looked at the route that has that 404, nothing seems particularly wrong with it.