Skip to content

Runes in ctlk core#796

Merged
clemsciences merged 5 commits intocltk:masterfrom
clemsciences:runes
Jul 10, 2018
Merged

Runes in ctlk core#796
clemsciences merged 5 commits intocltk:masterfrom
clemsciences:runes

Conversation

@clemsciences
Copy link
Copy Markdown
Member

This is my pull request following #794. The runes retrieval method will be added in a specific repository.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #796 into master will increase coverage by 0.02%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   88.49%   88.52%   +0.02%     
==========================================
  Files         161      162       +1     
  Lines       10155    10215      +60     
==========================================
+ Hits         8987     9043      +56     
- Misses       1168     1172       +4
Impacted Files Coverage Δ
cltk/tests/test_corpus.py 99.21% <100%> (+0.01%) ⬆️
cltk/corpus/old_norse/runes.py 91.83% <91.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b90691...37386a0. Read the comment docs.

Copy link
Copy Markdown
Member

@Sedictious Sedictious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! It may need some refactoring later on, should you want to add more features, but as of now, this should suffice!

@clemsciences
Copy link
Copy Markdown
Member Author

I need this step to be completed because I want to:

  • add more runic inscriptions,
  • use it for a Jupyter notebook in the tutorials,
  • to develop more features, it is easier to have the basic code already in the core code.

If you @Sedictious want to write code for runes, you can do it! Moreover, all the Germanic runes may be in a unique module, so some refactor will be needed

@clemsciences clemsciences merged commit 42cf4dd into cltk:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants