Skip to content

Added tutorials for South-Asian languages#19

Merged
kylepjohnson merged 4 commits intocltk:masterfrom
siddharthkv7:indian-languages-tutorials
Oct 5, 2018
Merged

Added tutorials for South-Asian languages#19
kylepjohnson merged 4 commits intocltk:masterfrom
siddharthkv7:indian-languages-tutorials

Conversation

@siddharthkv7
Copy link
Copy Markdown
Contributor

@kylepjohnson @clemsciences
I have tried to make tutorials for the Indian languages. Could you please review and let me know if any changes are to be made? :)

@clemsciences
Copy link
Copy Markdown
Member

For now, it looks great! I'm going to read your notebooks a bit later.

@clemsciences
Copy link
Copy Markdown
Member

I read all the notebooks and it seems to me that it is great! @kylepjohnson, there is a great work done here!

@siddharthkv7
Copy link
Copy Markdown
Contributor Author

@clemsciences Thanks for the appreciation! Meanwhile, is there something else that I can work upon maybe?

@clemsciences
Copy link
Copy Markdown
Member

@siddharthkv7 I don't know, maybe you can try to code features, that some Indian languages have, for Indian languages that don't (it's too late for me to write a syntactically correct sentence in English).

@kylepjohnson
Copy link
Copy Markdown
Member

Thank you @clemsciences for looking this over.

@siddharthkv7 There is one small change I would like you to do: Put all of your notebooks into one dir called south_asia. So: languages/south_asia/Bengali_tutorial.ipynb, languages/south_asia/Gujarati_tutorial.ipynb, etc..

I know that Tegulu is not Indo-European, but otherwise these languages have a lot in common and will have common users. I am open to reconsidering this, if and when we have many notebooks for a particular language.

@siddharthkv7
Copy link
Copy Markdown
Contributor Author

@kylepjohnson I'll do it right away :)
I just had a small doubt. Telugu is Dravidian as opposed to the other family of languages, which is Indo-Aryan (or Indo-European) . Same is the case with languages Kannada and Malayalam too. So, should I be including these tutorials or should we be dropping them?

@kylepjohnson
Copy link
Copy Markdown
Member

No, let's not drop them. I think the south_asia name is obvious enough for now. I'll merge this now.

@siddharthkv7 Are there any other tasks you want to work on?

@kylepjohnson kylepjohnson merged commit a5edfb7 into cltk:master Oct 5, 2018
@siddharthkv7
Copy link
Copy Markdown
Contributor Author

siddharthkv7 commented Oct 5, 2018

@kylepjohnson I am eager to work on more tasks! I was hoping if you could give me a few ideas hehe :P

@siddharthkv7 siddharthkv7 deleted the indian-languages-tutorials branch October 16, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants