Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tutorials for South-Asian languages #19

Merged
merged 4 commits into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@siddharthkv7
Copy link
Contributor

siddharthkv7 commented Oct 1, 2018

@kylepjohnson @clemsciences
I have tried to make tutorials for the Indian languages. Could you please review and let me know if any changes are to be made? :)

@clemsciences

This comment has been minimized.

Copy link
Member

clemsciences commented Oct 1, 2018

For now, it looks great! I'm going to read your notebooks a bit later.

@clemsciences

This comment has been minimized.

Copy link
Member

clemsciences commented Oct 2, 2018

I read all the notebooks and it seems to me that it is great! @kylepjohnson, there is a great work done here!

@siddharthkv7

This comment has been minimized.

Copy link
Contributor Author

siddharthkv7 commented Oct 2, 2018

@clemsciences Thanks for the appreciation! Meanwhile, is there something else that I can work upon maybe?

@clemsciences

This comment has been minimized.

Copy link
Member

clemsciences commented Oct 3, 2018

@siddharthkv7 I don't know, maybe you can try to code features, that some Indian languages have, for Indian languages that don't (it's too late for me to write a syntactically correct sentence in English).

@kylepjohnson

This comment has been minimized.

Copy link
Member

kylepjohnson commented Oct 4, 2018

Thank you @clemsciences for looking this over.

@siddharthkv7 There is one small change I would like you to do: Put all of your notebooks into one dir called south_asia. So: languages/south_asia/Bengali_tutorial.ipynb, languages/south_asia/Gujarati_tutorial.ipynb, etc..

I know that Tegulu is not Indo-European, but otherwise these languages have a lot in common and will have common users. I am open to reconsidering this, if and when we have many notebooks for a particular language.

@siddharthkv7

This comment has been minimized.

Copy link
Contributor Author

siddharthkv7 commented Oct 4, 2018

@kylepjohnson I'll do it right away :)
I just had a small doubt. Telugu is Dravidian as opposed to the other family of languages, which is Indo-Aryan (or Indo-European) . Same is the case with languages Kannada and Malayalam too. So, should I be including these tutorials or should we be dropping them?

@kylepjohnson

This comment has been minimized.

Copy link
Member

kylepjohnson commented Oct 5, 2018

No, let's not drop them. I think the south_asia name is obvious enough for now. I'll merge this now.

@siddharthkv7 Are there any other tasks you want to work on?

@kylepjohnson kylepjohnson merged commit a5edfb7 into cltk:master Oct 5, 2018

@siddharthkv7

This comment has been minimized.

Copy link
Contributor Author

siddharthkv7 commented Oct 5, 2018

@kylepjohnson I am eager to work on more tasks! I was hoping if you could give me a few ideas hehe :P

@siddharthkv7 siddharthkv7 deleted the siddharthkv7:indian-languages-tutorials branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.