Update test suite to ensure 100% code coverage#68
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CI pipeline and documentation to enforce and advertise 100% statement coverage for this library across the PHP test matrix.
Changes:
- Generates Clover coverage output in CI and adds a step to fail the job unless coverage is 100%.
- Adds
@codeCoverageIgnoreannotations to exclude a couple of hard-to-cover statements from coverage metrics. - Updates README with a 100% coverage badge and local coverage-report instructions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ProxyConnector.php |
Adds @codeCoverageIgnore markers to exclude specific statements from coverage. |
README.md |
Documents 100% coverage goal and adds a static 100% coverage badge plus local coverage command. |
.github/workflows/ci.yml |
Produces clover.xml and enforces 100% statement coverage via a PHP check step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the CI setup to ensure 100% code coverage.
Builds on top of #67 and clue/reactphp-eventsource#35