Skip to content

Conversation

@WyriHaximus
Copy link
Contributor

No description provided.

@clue
Copy link
Owner

clue commented Jul 26, 2014

Thanks @WyriHaximus, as always, your suggested PRs are very much appreciated 👍

Currently, we're only testing the oldest supported version and the latest release. Do you see a particular need to test intermediary versions?

I'm not saying we shouldn't merge this PR, but I'm a bit reluctant considering that we may end up with dozens of versions in the years to come :) I suppose this is not the first project to run into this, has any other project already achieved consensus?

@WyriHaximus
Copy link
Contributor Author

In my honest opinion we should test all versions we support. With the recent 5.5.13 BC break debacle, I prefer to know (at least in my personal projects) when something goes wrong with a new version. (Now I don't know how often Travis updates PHP binaries tbh.) It's also a save guard that everything works in all versions a project supports, and for my own projects I prefer only to support the PHP versions not EOL yet. So I don't see a big rise in PHP versions in this file any time soon 😄.

@clue
Copy link
Owner

clue commented Aug 31, 2014

[…] support the PHP versions not EOL yet. So I don't see a big rise in PHP versions […]

Agreed. Despite that I personally still don't see a particular need for testing intermediary versions for this library, I also don't see a particular reason to not test them.

So why hold this back? :) Thanks for the contribution! 👍

clue added a commit that referenced this pull request Aug 31, 2014
Test 5.4 and 5.5 just to be sure
@clue clue merged commit f73a5bf into clue:master Aug 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants