Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#72
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the project’s testing setup to ensure the test suite can run on legacy PHP 7.2 by allowing installation of PHPUnit 8.5, while also simplifying the CI workflow’s PHPUnit invocation across PHP versions.
Changes:
- Expand
require-devPHPUnit constraints to include^8.5so PHP 7.2 can resolve a compatible PHPUnit version. - Simplify the GitHub Actions CI workflow by collapsing the PHP-version conditional PHPUnit run steps into a single command with an inline conditional config flag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Adds PHPUnit ^8.5 to support running tests on PHP 7.2 while preserving compatibility across the existing PHP version range. |
| .github/workflows/ci.yml | Replaces two conditional PHPUnit steps with one step that conditionally applies -c phpunit.xml.legacy for PHP < 7.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5. This is needed to run the tests on legacy platforms due to recent upstream changes as discussed in clue/reactphp-redis#180.
Builds on top of #71 and clue/reactphp-redis#180