You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
packages/codev/src/terminal/__tests__/session-manager.test.ts has 3 integration tests that were originally guarded by `it.skipIf(!!process.env.CI)` — meaning they were skipped on CI but expected to run locally. They legitimately spawn real shellper processes.
While working on #903, the builder observed these 3 tests timing out locally (15s timeout exceeded) and proposed converting them to plain `it.skip`. That change was reverted from PR #904 as out-of-scope. This issue tracks proper investigation.
Affected tests
In `packages/codev/src/terminal/tests/session-manager.test.ts` (line numbers as of revert):
`'respects maxRestarts limit'` (around line 1020)
`'logs session exit without stderr tail (stderr goes to file)'` (around line 1724)
Context
packages/codev/src/terminal/__tests__/session-manager.test.tshas 3 integration tests that were originally guarded by `it.skipIf(!!process.env.CI)` — meaning they were skipped on CI but expected to run locally. They legitimately spawn real shellper processes.While working on #903, the builder observed these 3 tests timing out locally (15s timeout exceeded) and proposed converting them to plain `it.skip`. That change was reverted from PR #904 as out-of-scope. This issue tracks proper investigation.
Affected tests
In `packages/codev/src/terminal/tests/session-manager.test.ts` (line numbers as of revert):
What to investigate
Out of scope
Triggered by
doneidempotent on verified terminal state #904 review surfaced this; builder's well-intentioned skip was reverted to keep PR scope clean.