[Bugfix #562] Require --amends for --protocol tick#570
Merged
waleedkadous merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
…ong spec resolution
Contributor
Author
Architect ReviewLow-risk bugfix. Adds bidirectional validation: Architect review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #562
When
af spawn 5 --protocol tickis run without--amends, thespecLookupIdfalls back to the issue number instead of the spec being amended. This causes the builder to read the wrong spec file.Root Cause
In
spawn.ts, the spec lookup logic uses a conditional:When
--amendsis omitted,specLookupIddefaults toprojectId(the issue number), which resolves a different spec than intended. There was no validation requiring--amendsfor TICK protocol.Fix
Added validation in
validateSpawnOptions()that--protocol tickrequires--amends <spec-number>. This is the minimal Option A from the issue — fail fast with a clear error message rather than silently resolving the wrong spec.Test Plan
--protocol tickwithout--amendsreturns error