Skip to content

[Bugfix #577] Fix: Parse architect command flags via shell execution#578

Merged
waleedkadous merged 1 commit intomainfrom
fix/architect-command-parsing
Mar 1, 2026
Merged

[Bugfix #577] Fix: Parse architect command flags via shell execution#578
waleedkadous merged 1 commit intomainfrom
fix/architect-command-parsing

Conversation

@amrmelsayed
Copy link
Copy Markdown
Collaborator

@amrmelsayed amrmelsayed commented Feb 27, 2026

Summary

  • af architect fails with ENOENT when af-config.json contains command flags (e.g., "claude --dangerously-skip-permissions")
  • Node's spawn() without shell: true treats the full string as a literal binary name
  • Added shell: true to spawn options so the command is parsed by /bin/sh
  • Updated test assertions to match

Fixes #577

Copy link
Copy Markdown
Contributor

@waleedkadous waleedkadous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this! Good catch

@waleedkadous waleedkadous merged commit 29fb6c6 into main Mar 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

af architect fails with command strings that include flags

2 participants