Fix #667: Update E2E test for dashboard-dist path after monorepo restructure#668
Merged
waleedkadous merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
… monorepo restructure PR #666 moved the dashboard to packages/dashboard/ and changed the build output from dashboard/dist to dashboard-dist in packages/codev. The npm pack E2E test still expected the old path.
waleedkadous
deleted the
builder/bugfix-667-dashboard-e2e-npm-pack-missing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard E2E test (
dashboard-terminals.test.ts) was checking thatnpm packincludesdashboard/dist/index.html, but PR #666 moved the dashboard topackages/dashboard/and changed the build output todashboard-dist/. The test assertion was not updated to match.Fixes #667
Root Cause
PR #666 (VS Code extension monorepo restructure) changed:
build:dashboardscript fromcd dashboard && npm install && npm run buildtocd ../dashboard && npm run build && cp -r dist ../../packages/codev/dashboard-distfilesfield fromdashboard/disttodashboard-distThe E2E test was not updated to match the new path.
Fix
Updated the test assertions from
dashboard/dist/index.html→dashboard-dist/index.htmlanddashboard/dist/assets/→dashboard-dist/assets/.Test Plan
npm pack --dry-runconfirmsdashboard-dist/index.htmlis in the tarball