Skip to content

Fix #848: probe afx (not removed af) in verify-install.mjs#851

Merged
waleedkadous merged 6 commits into
mainfrom
builder/bugfix-848
May 25, 2026
Merged

Fix #848: probe afx (not removed af) in verify-install.mjs#851
waleedkadous merged 6 commits into
mainfrom
builder/bugfix-848

Conversation

@waleedkadous
Copy link
Copy Markdown
Contributor

Summary

The post-install CI verification script (packages/codev/scripts/verify-install.mjs) still listed the deprecated af bin that PR #847 removed from the package's bin map. The Tests workflow on main went red immediately after #847 merged (exit code 127 — command not found). Replace 'af' with 'afx' so the script verifies the canonical agent-farm entrypoint, which the script had never actually covered before.

Fixes #848

Root Cause

PR #847 dropped af from packages/codev/package.json's bin map but didn't update the parallel allowlist in scripts/verify-install.mjs:35. The iter-2 cleanup updated the e2e test (install.e2e.test.ts asserts AF_BIN does not exist) but missed this post-install CI script. As a side effect, the original script also never probed afx at all — it had been verifying the deprecated alias and not the canonical entrypoint.

Fix

One-character payload change:

-  const bins = ['codev', 'af', 'porch', 'consult'];
+  const bins = ['codev', 'afx', 'porch', 'consult'];

No other 'af' references remain under .github/ or packages/codev/scripts/ (grep clean per the acceptance criteria).

Test Plan

No dedicated unit test is added — verify-install.mjs is the test. It runs in the Package Install Verification job of .github/workflows/test.yml against a packed tarball after every push to main. The next post-merge run is the regression check; if the bin list ever drifts from package.json's bin map again, that workflow turns red immediately. The existing install.e2e.test.ts already asserts AF_BIN does not exist and AFX_BIN does, covering the source-level contract.

  • verify-install.mjs probes afx instead of af
  • No other workflow or script references the removed af bin
  • Local pnpm --filter @cluesmith/codev test passes
  • Local pnpm --filter @cluesmith/codev build passes
  • Post-merge Tests workflow on main goes green

The post-install CI verification script still listed the deprecated `af`
bin entry that PR #847 removed from the package's bin map. That made the
`Tests` workflow red on `main` immediately after #847 merged (exit code
127 — command not found).

Replace `'af'` with `'afx'` so the script verifies the canonical agent-farm
entrypoint (which was never actually covered before this).
3-way CMAP all APPROVE. Flagged out-of-scope: team/generate-image
not probed in verify-install.mjs (separate ticket).
@waleedkadous
Copy link
Copy Markdown
Contributor Author

Approved. Thanks for the fast turnaround — this unblocks CI which has been red since #847.

Right call to leave the team / generate-image script-scope expansion out of this PR. The issue scope was the missed af-bin fallout; broadening the allowlist convention is a separate question worth its own ticket.

Please merge.

@waleedkadous waleedkadous merged commit e937e59 into main May 25, 2026
6 checks passed
@waleedkadous waleedkadous deleted the builder/bugfix-848 branch May 25, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(verify-install): script still probes removed 'af' bin; missed in #847 cleanup; also never covered 'afx'

1 participant