Fix #848: probe afx (not removed af) in verify-install.mjs#851
Merged
Conversation
The post-install CI verification script still listed the deprecated `af` bin entry that PR #847 removed from the package's bin map. That made the `Tests` workflow red on `main` immediately after #847 merged (exit code 127 — command not found). Replace `'af'` with `'afx'` so the script verifies the canonical agent-farm entrypoint (which was never actually covered before this).
3-way CMAP all APPROVE. Flagged out-of-scope: team/generate-image not probed in verify-install.mjs (separate ticket).
Contributor
Author
|
Approved. Thanks for the fast turnaround — this unblocks CI which has been red since #847. Right call to leave the Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-install CI verification script (
packages/codev/scripts/verify-install.mjs) still listed the deprecatedafbin that PR #847 removed from the package's bin map. TheTestsworkflow onmainwent red immediately after #847 merged (exit code 127 — command not found). Replace'af'with'afx'so the script verifies the canonical agent-farm entrypoint, which the script had never actually covered before.Fixes #848
Root Cause
PR #847 dropped
affrompackages/codev/package.json's bin map but didn't update the parallel allowlist inscripts/verify-install.mjs:35. The iter-2 cleanup updated the e2e test (install.e2e.test.tsassertsAF_BINdoes not exist) but missed this post-install CI script. As a side effect, the original script also never probedafxat all — it had been verifying the deprecated alias and not the canonical entrypoint.Fix
One-character payload change:
No other
'af'references remain under.github/orpackages/codev/scripts/(grep clean per the acceptance criteria).Test Plan
No dedicated unit test is added —
verify-install.mjsis the test. It runs in thePackage Install Verificationjob of.github/workflows/test.ymlagainst a packed tarball after every push tomain. The next post-merge run is the regression check; if the bin list ever drifts frompackage.json's bin map again, that workflow turns red immediately. The existinginstall.e2e.test.tsalready assertsAF_BINdoes not exist andAFX_BINdoes, covering the source-level contract.verify-install.mjsprobesafxinstead ofafafbinpnpm --filter @cluesmith/codev testpassespnpm --filter @cluesmith/codev buildpassesTestsworkflow onmaingoes green