Skip to content

Bugfix #895: UPPERCASE area group headers in VSCode sidebar#897

Merged
amrmelsayed merged 5 commits into
mainfrom
builder/bugfix-895
May 28, 2026
Merged

Bugfix #895: UPPERCASE area group headers in VSCode sidebar#897
amrmelsayed merged 5 commits into
mainfrom
builder/bugfix-895

Conversation

@amrmelsayed
Copy link
Copy Markdown
Collaborator

Summary

Replaces the per-word capitalization shipped in #885 with a full uppercase transform for area group headers in the VSCode sidebar's Backlog and Builders trees. The new headers match VSCode's own container-label convention (EXPLORER, SOURCE CONTROL, etc.).

Before (#885) After
Vscode (4) VSCODE (4)
Tower (2) TOWER (2)
Cross Cutting (1) CROSS-CUTTING (1)
Uncategorized (0) UNCATEGORIZED (0)

The function is now a one-liner — area.toUpperCase() — and separators (-, _) are preserved verbatim instead of being split into spaces. cross-cutting now renders as CROSS-CUTTING, matching the issue's table exactly.

Changes

  • packages/core/src/area-grouping.ts: formatAreaForDisplay renamed to uppercaseAreaName; body collapsed to area.toUpperCase(); docstring updated.
  • packages/vscode/src/views/area-group-tree-item.ts: import + call site updated; docstring updated.
  • packages/vscode/src/test/area-grouping.test.ts: suite renamed; assertions rewritten against the new contract.

Out of scope

  • The wire-level area/* label values stay lowercase (external identifiers; Codev convention).
  • Other Codev sidebar headers already follow VSCode's container-label convention.

Test plan

  • pnpm --filter @cluesmith/codev-core build clean
  • pnpm --filter codev-vscode check-types clean
  • pnpm --filter codev-vscode lint clean
  • pnpm --filter codev-vscode test:unit — 49 pass
  • pnpm --filter codev-vscode compile-tests clean
  • Visual verification in running VSCode (architect to confirm at review)

Fixes #895

Supersedes #885's per-word capitalization with a full uppercase
transform, matching VSCode's own container-label convention
(EXPLORER, SOURCE CONTROL, etc.).

- `formatAreaForDisplay` renamed to `uppercaseAreaName`; implementation
  is now `area.toUpperCase()`.
- Separators are preserved verbatim: `cross-cutting` -> `CROSS-CUTTING`,
  `front_end` -> `FRONT_END`. The previous behavior split-and-rejoined
  with spaces; the new behavior is a single character-level transform.
- Tests rewritten against the new contract.
@amrmelsayed
Copy link
Copy Markdown
Collaborator Author

Architect Review

Trivial mechanical swap, exactly as specced. 63/36 across 5 files, but only 3 production files:

  • packages/core/src/area-grouping.ts (+10/-13) — capitalizeAreaNameuppercaseAreaName rename + toUpperCase() swap
  • packages/vscode/src/test/area-grouping.test.ts (+18/-19) — test cases updated for the rename + new behavior
  • packages/vscode/src/views/area-group-tree-item.ts (+4/-4) — caller updated for the rename

Net production change: ~25 LOC. Scope matches the issue body precisely.

Verdict

Approved. Please merge with: gh pr merge 897 --merge --admin.

Heads-up on the CHANGELOG flow

#885's CHANGELOG entry under [Unreleased] → What's new currently says "Area group headers are capitalized." Once #897 merges (which supersedes the capitalize-with-uppercase implementation), I'll rewrite the #885 entry to describe the final UPPERCASE behavior and reference both issues (#885, #895), rather than adding a confusingly-sequenced second entry. Both ship in the same release; users should see one accurate sentence about the final shipped behavior, not two contradictory ones.


Architect review

@amrmelsayed amrmelsayed merged commit 7633e57 into main May 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode: UPPERCASE area group header labels in backlog and builders trees (supersedes #885's Capitalized form)

1 participant