Bugfix #895: UPPERCASE area group headers in VSCode sidebar#897
Merged
Conversation
Supersedes #885's per-word capitalization with a full uppercase transform, matching VSCode's own container-label convention (EXPLORER, SOURCE CONTROL, etc.). - `formatAreaForDisplay` renamed to `uppercaseAreaName`; implementation is now `area.toUpperCase()`. - Separators are preserved verbatim: `cross-cutting` -> `CROSS-CUTTING`, `front_end` -> `FRONT_END`. The previous behavior split-and-rejoined with spaces; the new behavior is a single character-level transform. - Tests rewritten against the new contract.
Collaborator
Author
Architect ReviewTrivial mechanical swap, exactly as specced. 63/36 across 5 files, but only 3 production files:
Net production change: ~25 LOC. Scope matches the issue body precisely. VerdictApproved. Please merge with: Heads-up on the CHANGELOG flow#885's CHANGELOG entry under Architect review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the per-word capitalization shipped in #885 with a full uppercase transform for area group headers in the VSCode sidebar's Backlog and Builders trees. The new headers match VSCode's own container-label convention (EXPLORER, SOURCE CONTROL, etc.).
Vscode (4)VSCODE (4)Tower (2)TOWER (2)Cross Cutting (1)CROSS-CUTTING (1)Uncategorized (0)UNCATEGORIZED (0)The function is now a one-liner —
area.toUpperCase()— and separators (-,_) are preserved verbatim instead of being split into spaces.cross-cuttingnow renders asCROSS-CUTTING, matching the issue's table exactly.Changes
packages/core/src/area-grouping.ts:formatAreaForDisplayrenamed touppercaseAreaName; body collapsed toarea.toUpperCase(); docstring updated.packages/vscode/src/views/area-group-tree-item.ts: import + call site updated; docstring updated.packages/vscode/src/test/area-grouping.test.ts: suite renamed; assertions rewritten against the new contract.Out of scope
area/*label values stay lowercase (external identifiers; Codev convention).Test plan
pnpm --filter @cluesmith/codev-core buildcleanpnpm --filter codev-vscode check-typescleanpnpm --filter codev-vscode lintcleanpnpm --filter codev-vscode test:unit— 49 passpnpm --filter codev-vscode compile-testscleanFixes #895