Reimplement Interval and remove dependency on ai.lum.common#3
Merged
MihaiSurdeanu merged 2 commits intofor-releasefrom May 8, 2026
Merged
Reimplement Interval and remove dependency on ai.lum.common#3MihaiSurdeanu merged 2 commits intofor-releasefrom
MihaiSurdeanu merged 2 commits intofor-releasefrom
Conversation
Contributor
MihaiSurdeanu
left a comment
MihaiSurdeanu
left a comment
There was a problem hiding this comment.
LGTM! Thanks @kwalcock !
MihaiSurdeanu
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several ways to fix the issue and this might not be the best depending on where nxmlreader will be used. The package for Interval has changed from ai.lum.common to ai.lum.nxmlreader. This is because something like reach uses both common and nxmlreader projects and the two Intervals would conflict if one was not renamed. Therefore, there are minimal changes to the import statements needed in reach to deal with the change. The other option is to update the ai.lum.common project release and I will probably be doing that soon anyway.