Escape arguments when installer invokes commands#652
Merged
psihius merged 2 commits intoclusterio:masterfrom Sep 2, 2024
Merged
Escape arguments when installer invokes commands#652psihius merged 2 commits intoclusterio:masterfrom
psihius merged 2 commits intoclusterio:masterfrom
Conversation
The usage of shell: true means that no escaping is done on the arguments passed to the commands invoked by the installer. This leads to the installation failing if the user for example puts a space in the username for the admin account. Fix by escaping the arguments passed on command lines. This is unreasonably complicated on Windows 😡.
The @swc/core module depends on optional dependencies being installed in order to get the correct native binding's package installed. Remove --no-optional flag passed to pnpm to install these.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
- Coverage 77.00% 76.87% -0.13%
==========================================
Files 106 107 +1
Lines 10072 10099 +27
Branches 1671 1671
==========================================
+ Hits 7756 7764 +8
- Misses 1792 1812 +20
+ Partials 524 523 -1 ☔ View full report in Codecov by Sentry. |
psihius
approved these changes
Sep 2, 2024
Danielv123
approved these changes
Sep 2, 2024
Hornwitser
added a commit
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of shell: true means that no escaping is done on the arguments passed to the commands invoked by the installer. This leads to the installation failing if the user for example puts a space in the username for the admin account.
Fix by escaping the arguments passed on command lines. This is unreasonably complicated on Windows 😡.
Resolves #620.