controlplane/control: Support port updates #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 25, 2024
kfirtoledo
requested changes
Feb 25, 2024
elevran
reviewed
Feb 26, 2024
pkg/controlplane/control/manager.go
Outdated
| return nil | ||
| newPort := imp.Spec.TargetPort == 0 | ||
|
|
||
| port, err := m.ports.Lease(imp.Name, imp.Spec.TargetPort) |
Collaborator
There was a problem hiding this comment.
Can you have the same import name in different namespaces? If so, they'd be treated as the same and it would be better to use a NamespacedName for the leasing inport
kfirtoledo
approved these changes
Feb 28, 2024
orozery
force-pushed
the
portmanager
branch
2 times, most recently
from
a03a864 to
8093784
Compare
This commit adds support for updating import target ports. Signed-off-by: Or Ozeri <oro@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for updating import target ports.
It also adds support for automatic port allocation in CRD mode.