-
-
Notifications
You must be signed in to change notification settings - Fork 222
enhance/Prompt #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance/Prompt #503
Conversation
Improving the prompt in settings.js
Improving the prompt in setup.js
|
Honestly, I'd rather see this as an configurable prefix and postfix to the prompt (in settings). While I like the idea of discussing & improving those parts altogether, I think this might lead to a lot of PRs for this topic -- leaving those that can't code in the dust. |
|
Lets keep this for Prompt enhancement either the prompt itself or the tech/dev side |
|
This pull request has been marked as stale due to inactivity. Please update it to keep it open. |
|
Honestly, I think this enhanced prompt in this PR has yielded much better results for me, |
|
@troponaut They don't want to merge it :) I perfected it for this specific task |
Wie kommst du darauf das (nicht WIR, wenn ICH) das nicht mergen will? Ich habe mir einige Wochen freigenommen und habe keine Zeit gehabt auf alles bisher hier einzugehen. |
We are not aware you are off |
Do I have to inform anyone about beeing away for a time? Sorry for not beeing that fast. Grüße aus Köln nach Köln 😂 |
Changed console.error to console.warn for non-blocking failures. Return true on errors to skip validation instead of failing.
|
Ah sorry, but you @clusterzx really did a great job. BG |
|
Thank you 😅 I tried to keep up with everything but man I gotta say that's tough. The new improvement is so simple but gold to close some long time issues. I am in the last steps of the RAG Service I worked on, after that I will merge your prompt and also the skip validation fix. Maybe just one more day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your PR to just the improved Prompt.
I implement a better approach on validation errors. But this makes the complete pre-flight check on setup unnecessary. When a user just types in trash while setup and the checks are ignored they would open up massive new issues here, just because they got no feedback what was wrong.
|
In this case we will need to implement a notification message there, to alert? |
|
This pull request has been marked as stale due to inactivity. Please update it to keep it open. |
|
This pull request has been closed due to lack of response. |
I only enhanced the prompt example for better management