Skip to content

Conversation

@SilentJMA
Copy link

@SilentJMA SilentJMA commented May 4, 2025

I only enhanced the prompt example for better management

  • Explicitly handles multi-document PDFs (tags, title suffixes, "Mixed Document Packet" type)
  • Strict rules for dates (DD-MM-YYYY), language, and tag selection
  • More structured for complex cases

SilentJMA added 2 commits May 4, 2025 15:28
Improving the prompt in settings.js
Improving the prompt in setup.js
@habitoti
Copy link

habitoti commented May 6, 2025

Honestly, I'd rather see this as an configurable prefix and postfix to the prompt (in settings). While I like the idea of discussing & improving those parts altogether, I think this might lead to a lot of PRs for this topic -- leaving those that can't code in the dust.

@SilentJMA
Copy link
Author

Lets keep this for Prompt enhancement either the prompt itself or the tech/dev side

@clusterzx
Copy link
Owner

This pull request has been marked as stale due to inactivity. Please update it to keep it open.

@troponaut
Copy link

Honestly, I think this enhanced prompt in this PR has yielded much better results for me,

@SilentJMA
Copy link
Author

@troponaut They don't want to merge it :) I perfected it for this specific task

@clusterzx clusterzx removed the stale label May 17, 2025
@clusterzx
Copy link
Owner

@troponaut They don't want to merge it :) I perfected it for this specific task

Wie kommst du darauf das (nicht WIR, wenn ICH) das nicht mergen will? Ich habe mir einige Wochen freigenommen und habe keine Zeit gehabt auf alles bisher hier einzugehen.

@SilentJMA
Copy link
Author

@troponaut They don't want to merge it :) I perfected it for this specific task

Wie kommst du darauf das (nicht WIR, wenn ICH) das nicht mergen will? Ich habe mir einige Wochen freigenommen und habe keine Zeit gehabt auf alles bisher hier einzugehen.

We are not aware you are off

@clusterzx
Copy link
Owner

@troponaut They don't want to merge it :) I perfected it for this specific task

Wie kommst du darauf das (nicht WIR, wenn ICH) das nicht mergen will? Ich habe mir einige Wochen freigenommen und habe keine Zeit gehabt auf alles bisher hier einzugehen.

We are not aware you are off

Do I have to inform anyone about beeing away for a time?
I mean this is an open source project only maintained by me as one person.

Sorry for not beeing that fast.

Grüße aus Köln nach Köln 😂

Changed console.error to console.warn for non-blocking failures.
Return true on errors to skip validation instead of failing.
@SilentJMA
Copy link
Author

Ah sorry, but you @clusterzx really did a great job.
I've modified the setupService.js to throw only soft failure and skip validation instead of failing.

BG

@clusterzx
Copy link
Owner

Thank you 😅 I tried to keep up with everything but man I gotta say that's tough.

The new improvement is so simple but gold to close some long time issues.

I am in the last steps of the RAG Service I worked on, after that I will merge your prompt and also the skip validation fix.

Maybe just one more day.

Copy link
Owner

@clusterzx clusterzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your PR to just the improved Prompt.

I implement a better approach on validation errors. But this makes the complete pre-flight check on setup unnecessary. When a user just types in trash while setup and the checks are ignored they would open up massive new issues here, just because they got no feedback what was wrong.

@SilentJMA
Copy link
Author

In this case we will need to implement a notification message there, to alert?

@clusterzx
Copy link
Owner

This pull request has been marked as stale due to inactivity. Please update it to keep it open.

@clusterzx clusterzx added the stale label Jun 1, 2025
@clusterzx
Copy link
Owner

This pull request has been closed due to lack of response.

@clusterzx clusterzx closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants