Add support for ssrc attributes with dashes. #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM |
ibc
added a commit
to ibc/libsdptransform
that referenced
this pull request
Jan 5, 2018
Owner
|
Hey, thanks a lot for fixing this. Will bump a patch version for it in a bit :-) |
Owner
|
In 2.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a scenario where a
a=ssrcline was not being parsed properly; the regex was not checking for-characters. Thessrcattribute in question isprevious-ssrc(RFC 5576).This change modifies the
ssrcgrammar regex to allow for-in the attribute name, and adds a test case for it.