Adds support for label attribute per RFC 4574. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-j-ackso
changed the title
Owner
|
Hey, thanks a lot. This all seems sensible to me. Code is simple enough so happy to release this. Would you like to add a line or two in tests while you are at it? 🙂 |
Contributor
Author
|
Thanks! Regarding tests, were you hoping for something specific to this PR or more in general? |
Owner
|
Just a line with a label in one of the sample sdps and a line that reads it in the tests say. |
Owner
|
The hacky.sdp is the usual victim of new properties 🙂 |
Contributor
Author
|
Cool, I'll get that together right now! |
Owner
|
That looks sufficient. Thank you very much! |
Owner
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
labelattribute per RFC 4574.Resolves #74.