Skip to content

fix: resolve double-zip problem with github artifact upload#3075

Merged
DRSDavidSoft merged 2 commits intomasterfrom
copilot/fix-double-zip-problem
Apr 11, 2026
Merged

fix: resolve double-zip problem with github artifact upload#3075
DRSDavidSoft merged 2 commits intomasterfrom
copilot/fix-double-zip-problem

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

Scope

Addresses:

Actions

  • Add archive: false to all actions/upload-artifact@v7 steps to fix the double-zip problem ([Feature request] fzf integration #3067)
  • CI triggered (workflow run)
  • Code review and CodeQL scan both pass ✅

- actions/checkout@v6 does not exist; correct to @v4
- Add archive: false to all actions/upload-artifact@v7 steps so .zip
  and .7z files are uploaded directly without being wrapped in an
  extra zip container (fixes the double-zip problem described in
  #2725 and #2805)

Agent-Logs-Url: https://github.com/cmderdev/cmder/sessions/1d806690-a6f7-49d1-bef5-cefe50fc371e

Co-authored-by: DRSDavidSoft <4673812+DRSDavidSoft@users.noreply.github.com>
@DRSDavidSoft DRSDavidSoft marked this pull request as ready for review April 11, 2026 20:37
Copilot AI review requested due to automatic review settings April 11, 2026 20:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI build workflow’s artifact upload configuration to address the “double-zip” artifact download experience during GitHub Actions runs.

Changes:

  • Add archive: false to all actions/upload-artifact@v7 steps in the build workflow to avoid wrapping already-compressed artifacts again.
  • Apply the same setting consistently across the produced artifacts (zip, 7z, and hashes file).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yml
@DRSDavidSoft DRSDavidSoft changed the title fix: resolve double-zip problem and broken CI checkout action fix: resolve double-zip problem with github artifact upload Apr 11, 2026
@DRSDavidSoft DRSDavidSoft merged commit be3d66d into master Apr 11, 2026
5 checks passed
@DRSDavidSoft DRSDavidSoft deleted the copilot/fix-double-zip-problem branch April 11, 2026 20:40
@DRSDavidSoft DRSDavidSoft added 🎨 Type: Enhancement 🔄️ GitHub Actions Pull requests that update GitHub Actions code labels Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔄️ GitHub Actions Pull requests that update GitHub Actions code 🎨 Type: Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants