-
Notifications
You must be signed in to change notification settings - Fork 8
point all download links to GitHub's latest release page
#17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That's good because I presume those are your google tracking links? Might have to think about what this change does to the stats if you're tracking it. |
|
Yeah I wasn't sure how best to handle it but I think it is fine, it will still track how many people are interested in the different editions, only downside is that they have to click twice now. |
MartiUK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are download buttons, I don't think it's right to redirect to the release page in github, when a user would be expecting a download.
|
@MartiUK any suggestions then on how to better handle this? Don't list the files at all and just say "Download the latest release on our GitHub page"? I didn't do that because I didn't want you to lose the analytics data. |
|
The analytics isn't in my control, I assume it's with @samvasko. We can do this for now, I'm working on a solution that'll use the github api. |
|
Do what now? The current PR or my last suggestion? |
|
Current PR |
|
Alright, I can't merge myself btw. |
No description provided.