Skip to content

Conversation

@Stanzilla
Copy link
Member

No description provided.

@Jackbennett
Copy link
Collaborator

Jackbennett commented Nov 3, 2017

I see marti has a review request. I learned how to use the request review button.

That's good because I presume those are your google tracking links? Might have to think about what this change does to the stats if you're tracking it.

@Jackbennett Jackbennett requested a review from MartiUK November 3, 2017 19:13
@Stanzilla
Copy link
Member Author

Yeah I wasn't sure how best to handle it but I think it is fine, it will still track how many people are interested in the different editions, only downside is that they have to click twice now.

@Stanzilla
Copy link
Member Author

@MartiUK

Copy link
Member

@MartiUK MartiUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are download buttons, I don't think it's right to redirect to the release page in github, when a user would be expecting a download.

@MartiUK MartiUK self-assigned this Nov 15, 2017
@Stanzilla
Copy link
Member Author

Stanzilla commented Nov 15, 2017

@MartiUK any suggestions then on how to better handle this? Don't list the files at all and just say "Download the latest release on our GitHub page"? I didn't do that because I didn't want you to lose the analytics data.

@MartiUK
Copy link
Member

MartiUK commented Nov 15, 2017

The analytics isn't in my control, I assume it's with @samvasko.

We can do this for now, I'm working on a solution that'll use the github api.

@Stanzilla
Copy link
Member Author

Do what now? The current PR or my last suggestion?

@MartiUK
Copy link
Member

MartiUK commented Nov 15, 2017

Current PR

@Stanzilla
Copy link
Member Author

Alright, I can't merge myself btw.

@MartiUK MartiUK merged commit efb9f40 into cmderdev:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants