Skip to content

Conversation

@DRSDavidSoft
Copy link
Contributor

@DRSDavidSoft DRSDavidSoft commented Apr 21, 2018

I'm working on a rewrite of the Cmder.net website, which fixes some unreadability mentioned in #15 and adds some Javascript for a better user experience.

Responsiveness

This patch replaces the lemonade.css (a simple grid system) with more robust bootstrap. Since the bootstrap v4.0 by default uses flexboxes instead of manual widths, the content will be shown on mobile beautifully:

This essentially fixes #15.

@DRSDavidSoft DRSDavidSoft changed the title Patch for #2 – Replaces lemonade.css with bootstrap v4 Fixes #2 – Replaces lemonade.css with bootstrap v4 Apr 21, 2018
@Stanzilla
Copy link
Member

@DRSDavidSoft try with DRSDavidSoft#5

@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Apr 22, 2018

@Stanzilla Thanks, seems to have fixed the CI problem!

EDIT: Oh no, it still has the error:
External link https://gitforwindows.org/ failed: response code 0 means something's wrong.

@Stanzilla
Copy link
Member

I don't even understand why it wants to curl that...

@DRSDavidSoft
Copy link
Contributor Author

gem "html-proofer"

The html-proofer wants to check all the links and make sure they're valid, but git for windows website already works 😕

disable external sites checking for htmlproofer
@Stanzilla
Copy link
Member

try DRSDavidSoft#6

@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Apr 22, 2018

@Stanzilla Hm, this seems to do it. I'm also merging your commits into my rewrite branch, this release-pr branch is for creating the pull request.

Also, have a look at this if you're interested: (git clone it first)
https://github.com/DRSDavidSoft/cmder-site/blob/feat/interactive-cmder/.workspace/cmder-web.html

git clone https://github.com/DRSDavidSoft/cmderdev.github.io.git

@Stanzilla
Copy link
Member

Hah, that's neat, what are your plans for it?

@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Apr 22, 2018

@Stanzilla I have explained it here: DRSDavidSoft#12 (comment)

merged nit commits from release-pr into rewrite, thanks @Stanzilla
* Delete cmder.ico

* Delete cmder-web.html

* Delete bg.jpg

* Delete font.css

* Delete marlett.eot

* Delete marlett.svg

* Delete marlett.ttf

* Delete marlett.woff

* Delete marlett.woff2
@DRSDavidSoft
Copy link
Contributor Author

Ready to merge

Please squash and merge to avoid multiple commits.
(CC'd @Stanzilla @MartiUK @Jackbennett)

Awaiting your response

@Stanzilla
Copy link
Member

Looks good! 👌 I don't have permissions on the repo so gotta wait for the other guys :)

@DRSDavidSoft DRSDavidSoft reopened this May 1, 2018
@MartiUK MartiUK merged commit b875478 into cmderdev:master May 8, 2018
@MartiUK
Copy link
Member

MartiUK commented May 8, 2018

LGTM 👍

@DRSDavidSoft DRSDavidSoft deleted the release-pr branch May 8, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site isn't very mobile friendly

3 participants