This repository was archived by the owner on Feb 12, 2026. It is now read-only.
Make compatible with new tf_mem version that uses array for nentries …#16
Merged
Make compatible with new tf_mem version that uses array for nentries …#16
Conversation
pwittich
approved these changes
Mar 14, 2021
Contributor
pwittich
left a comment
pwittich
left a comment
There was a problem hiding this comment.
Nice to add comments to the functions to explain further. We should probably move towards adding docstrings rather than comments in with a prepended "#", that is more pythonic and easier to look at. See e.g. this stack exchange post
Contributor
Author
Done. All non-trivial functions in WriteVHDLSyntax.py now have a comment explaining their purpose. And all such comments in any function in WriteVHDLSyntax.py, WriteHDLUtils.py or generator_hdl.py now enclosed in triple quotes. |
Contributor
|
In the future the docstrings don't need a comment character. |
rzouCERN
pushed a commit
that referenced
this pull request
May 28, 2021
#16) * Make compatible with new tf_mem version that uses array for nentries port * Use triple quotes for all comments explaining a function
tomalin
added a commit
that referenced
this pull request
Jun 8, 2021
* iterate through list of memModules * working on fixing chain * templatepars returns empty string * resolved some bugs with memory lists * fixed more list stuff * fix top level file to include all needed modules * get rid of old comment * comment out lines * works for current firmware * add lut tables to top level * cleanup * finish adding luts * dividing VMStubsTE into VMStubsTEInner and VMStubsTEOuter as VMStubsTEOuter is binned memory * fixing typos * undo userlabel addition, fixing matchArgPortNames_TC. fixing writeModuleInst_generic so that it works for portname like outervmstubin * fixing typos * iterate through list of memModules * Make compatible with new tf_mem version that uses array for nentries … (#16) * Make compatible with new tf_mem version that uses array for nentries port * Use triple quotes for all comments explaining a function * working on fixing chain * templatepars returns empty string * resolved some bugs with memory lists * resolving conflicts due to rebase * fixed more list stuff * fix top level file to include all needed modules * get rid of old comment * comment out lines * works for current firmware * add lut tables to top level * cleanup * finish adding luts * dividing VMStubsTE into VMStubsTEInner and VMStubsTEOuter as VMStubsTEOuter is binned memory * fixing typos * undo userlabel addition, fixing matchArgPortNames_TC. fixing writeModuleInst_generic so that it works for portname like outervmstubin * fixing typos * simplifying hls ip name for TE as we can use the same ip for all TEs. fix t_arr_8_5b * fixing small bug with trackpar TE * fixing index for projout ports on TC * getting rid of D5 for projout ports on TC * adding back D5 for projout ports on TC * moving LUT detection in WriteHDLUtils.py. fixing TE ipname to include seed layers * removing pointless checks on memModule being a list * adding TETC chain example to README Co-authored-by: Fatima Yousef <fy56@lnx231.classe.cornell.edu> Co-authored-by: Rui Zou <rz393@cornell.edu> Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update makes the VHDL written by the scripts compatible with the new tf_mem*.vhd interface created by HLS PR cms-L1TK/firmware-hls#135 (which has now been merged) . It means that the assignment of the "nent_o" port of the memories is now done in a single line of VHDL for each memory.
To do this, the signals "nentries" inside the SectorProcessor.vhd written by the scripts are now arrays, with one element for each page of the memory.