Skip to content

Conversation

@SenneVanPutte
Copy link
Contributor

@SenneVanPutte SenneVanPutte commented Sep 11, 2020

Moving txt files to here as requested in
cms-sw/cmssw#31376

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SenneVanPutte for branch master.

@smuzaffar, @christopheralanwest, @mrodozov, @tocheng, @cmsbuild, @tlampen, @pohsun, @tulamor can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
cms-bot commands are listed here

@mrodozov
Copy link

remove them from cms-sw/cmssw#31376

@SenneVanPutte
Copy link
Contributor Author

I was waiting for them to be added here, so I can test out the TkAlMap implementation in this setup.
But if you prefer I can remove them, and alter the setup in two different commits.

@mrodozov
Copy link

mrodozov commented Sep 11, 2020

You don't have to alter anything if the alteration you mean is about how do you refer to the files. they should be refered to as they were i.e.
Alignment/OfflineValidation/data/TkAlMap/Relative_TPolyLine_Pixel_BPIX_L1.txt
you just have to mention this pull request like this in 31376:
please test with https://github.com/cms-data/Alignment-OfflineValidation/pull/1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31376

@cmsbuild
Copy link
Contributor

+1
Tested at: fe1f1bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-628946/9262/summary.html
CMSSW: CMSSW_11_2_X_2020-09-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-628946/9262/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2620305
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2620282
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31376

@cmsbuild
Copy link
Contributor

+1
Tested at: fe1f1bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-628946/9319/summary.html
CMSSW: CMSSW_11_2_X_2020-09-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-628946/9319/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2620306
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2620272
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@tlampen
Copy link

tlampen commented Sep 15, 2020

+alca

@mrodozov
Copy link

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants