Fixed access to local FS for input files + minor refactoring of AnalysisTools.h#242
Merged
kandrosov merged 12 commits intocms-flaf:mainfrom May 1, 2026
Merged
Fixed access to local FS for input files + minor refactoring of AnalysisTools.h#242kandrosov merged 12 commits intocms-flaf:mainfrom
kandrosov merged 12 commits intocms-flaf:mainfrom
Conversation
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14651062 started |
Collaborator
|
pipeline#14651062 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14651504 started |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14651971 started |
Collaborator
|
pipeline#14651504 failed |
Collaborator
|
pipeline#14651971 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14652961 started |
Collaborator
|
pipeline#14652961 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14653993 started |
Collaborator
|
pipeline#14653993 passed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14669128 started |
Collaborator
|
pipeline#14669128 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14669473 started |
Collaborator
|
pipeline#14669473 failed |
Collaborator
|
pipeline#14669473 passed |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates FLAF’s workflow and utilities to better support running with input/output on the local filesystem, while also refactoring vector-ops helpers and updating a few environment/config defaults.
Changes:
- Add local filesystem handling in LAW filesystem/target construction and update tasks to use absolute paths for localized I/O.
- Refactor
v_opsp4 component extractors and add a newTakeAndCasthelper inAnalysisTools.h. - Update defaults/configs (CMSSW version/compiler defaults, integration task target, and a few dataset NanoAOD dataset paths).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| run_tools/law_customizations.py | Extend remote_target logic for local FS targets. |
| include/AnalysisTools.h | Refactor v_ops extractors and introduce ROOT::VecOps::TakeAndCast. |
| env.sh | Switch default CMSSW version/compiler. |
| config/Run3_2023/datasets.yaml | Update DY NanoAOD v12 dataset path revision. |
| config/Run3_2022EE/datasets.yaml | Update DY NanoAOD v12 dataset path revision. |
| config/Run3_2022/datasets.yaml | Update DY NanoAOD v12 dataset path revision. |
| Common/Setup.py | Return a law.LocalFileSystem for absolute local paths. |
| Common/BaselineSelection.py | Allow selecting a specific MET collection when defining reco p4s. |
| Analysis/tasks.py | Use absolute paths for inputs/outputs when running producers and moving localized outputs. |
| AnaProd/tasks.py | Use absolute paths for localized I/O and guard file_interface access. |
| AnaProd/anaTupleProducer.py | Pass met_type through to reco p4 selection. |
| .github/integration_cfg.yaml | Switch HH_bbWW integration task to FLAF.Analysis.tasks.HistPlotTask. |
Comments suppressed due to low confidence (1)
run_tools/law_customizations.py:140
remote_dir_targetstill only special-casesfswhen it is astr. WithCommon/Setup.pynow potentially returning alaw.LocalFileSystemfor local paths, passing such an FS intoremote_dir_targetwill currently fall through toWLCGDirectoryTarget(path, fs), which is incompatible. Consider adding the sameLocalFileSystemhandling here as inremote_target(returninglaw.LocalDirectoryTarget(path, fs=fs)).
def remote_dir_target(self, *path, fs=None):
fs = fs or self.fs_default
path = os.path.join(*path)
if type(fs) == str:
path = os.path.join(fs, path)
return law.LocalDirectoryTarget(path)
return WLCGDirectoryTarget(path, fs)
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14669977 started |
Collaborator
|
pipeline#14669977 passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.