Bug fixes 20180405#15
Merged
aperloff merged 4 commits intocms-jet:masterfrom Apr 6, 2018
Merged
Conversation
Member
|
I'm happy with these. Have you tested that the code works (it compiles, no crashes, and you get the expected output)? |
Collaborator
Author
|
Hello, thanks for reviewing the change. I have checked out (from scratch) and run the modified code and I get the expected output. |
Member
|
Awesome. Then I shall merge in these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bug fixes
These fixes are quite straightforward and shouldn't interfere with anything else.
Best regards,
Yi Chen