moduleAllocMonitor diff table: remove unused Record column. If moduleAllocMonitor json metrics changed compare to self in PR. by gartung · Pull Request #2732 · cms-sw/cms-bot

gartung · 2026-04-29T16:33:18Z

No description provided.

…compare to self. Co-authored-by: Copilot <copilot@github.com>

… PR and diff to match the number in columns. Co-authored-by: Copilot <copilot@github.com>

cmsbuild · 2026-04-29T16:33:42Z

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2026-04-29T16:33:43Z

cms-bot internal usage

cmsbuild · 2026-04-29T16:37:02Z

Pull request #2732 was updated.

gartung · 2026-04-29T16:46:15Z

test parameters:

workflows_profiling = 18634.0
enable = profiling

gartung · 2026-04-29T16:46:42Z

please test with cms-sw/cmssw#50822

cmsbuild · 2026-04-29T18:18:05Z

Pull request #2732 was updated.

cmsbuild · 2026-04-29T20:12:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31805e/52956/summary.html
COMMIT: 31c7e31
CMSSW: CMSSW_17_0_X_2026-04-29-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2732/52956/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186963
DQMHistoTests: Total failures: 61
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186882
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: found differences in 1 / 51 workflows

makortel · 2026-04-29T21:29:14Z

+    if grep "Error: input files describe different metrics" $f.log ; then
+        echo "IB and PR files describe different metrics, comparing to self for diff<BR>" >> $WORKSPACE/upload/profiling/index-$PROFILING_WORKFLOW.html || true


It would be kind of nice to be able to deal with different sets of transitions in the diff, but maybe such situations will be rare enough that the effort for that is not really worth it.

Can this PR be merged and the different sets of transitions be solved in another PR?

makortel · 2026-04-29T21:31:39Z

Where is the order of the transitions in the dropdown (and in the per-module tables) specified?

It would be nice if the order would be the same as in
https://github.com/cms-sw/cmssw/blob/982ab6323e0bf18367878f8eff42f07021be4945/PerfTools/AllocMonitor/scripts/edmModuleAllocJsonToCircles.py#L13-L33
It seems to me the orders in these two places are close to each other, but not quite the same.

gartung · 2026-04-29T21:42:39Z

The extra transitions were discovered and added to the drop-down list. I will update to set the correct order.

cmsbuild · 2026-04-29T21:50:54Z

Pull request #2732 was updated.

gartung · 2026-04-29T21:58:10Z

please test with cms-sw/cmssw#50822

cmsbuild · 2026-04-29T23:59:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31805e/52961/summary.html
COMMIT: 80bb6ef
CMSSW: CMSSW_17_0_X_2026-04-29-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2732/52961/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186963
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186936
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

gartung and others added 2 commits April 29, 2026 11:29

Add special case where PR adds metrics to moduleAllocMonitor json -- …

af1c0f4

…compare to self. Co-authored-by: Copilot <copilot@github.com>

Remove unused Record column. Use right justified column header for IB…

a178203

… PR and diff to match the number in columns. Co-authored-by: Copilot <copilot@github.com>

cmsbuild added orp-pending pending-signatures externals-pending tests-pending labels Apr 29, 2026

gartung mentioned this pull request Apr 29, 2026

PerfTools/AllocMonitor: Add additional transition types to moduleAllocMonitor circles json. cms-sw/cmssw#50822

Open

Add message to summary page that comparison was to self for test.

b8630a8

gartung linked an issue Apr 29, 2026 that may be closed by this pull request

Remove Record column from moduleAllocMonitor diff table. Right align IB, PR, diff column headers. Compare PR results to self when format changes. cms-sw/framework-team#2192

Open

cmsbuild added tests-started requires-external and removed tests-pending labels Apr 29, 2026

Add line break in cell

31c7e31

cmsbuild added tests-pending and removed tests-started requires-external labels Apr 29, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Apr 29, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2026

makortel reviewed Apr 29, 2026

View reviewed changes

Add new transtions in the order they are executed

80bb6ef

cmsbuild added tests-pending and removed tests-approved requires-external labels Apr 29, 2026

cmsbuild added tests-started requires-external tests-pending and removed tests-pending tests-started requires-external labels Apr 29, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Apr 29, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2026

gartung changed the title ~~moduleAllocMonitor diff table: remove unused Record column. If moduleAllocMonitor json metrics change compare to self in PR.~~ moduleAllocMonitor diff table: remove unused Record column. If moduleAllocMonitor json metrics changed compare to self in PR. May 1, 2026

		if grep "Error: input files describe different metrics" $f.log ; then
		echo "IB and PR files describe different metrics, comparing to self for diff<BR>" >> $WORKSPACE/upload/profiling/index-$PROFILING_WORKFLOW.html \|\| true

Conversation

gartung commented Apr 29, 2026

Uh oh!

cmsbuild commented Apr 29, 2026

Uh oh!

cmsbuild commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 29, 2026

Uh oh!

gartung commented Apr 29, 2026

Uh oh!

gartung commented Apr 29, 2026

Uh oh!

cmsbuild commented Apr 29, 2026

Uh oh!

cmsbuild commented Apr 29, 2026

Comparison Summary

Uh oh!

makortel Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

gartung Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

gartung Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

makortel commented Apr 29, 2026

Uh oh!

gartung commented Apr 29, 2026

Uh oh!

cmsbuild commented Apr 29, 2026

Uh oh!

gartung commented Apr 29, 2026

Uh oh!

cmsbuild commented Apr 29, 2026

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Apr 29, 2026 •

edited

Loading