Skip to content

Old bot: fix parsing of test command (use empty-string instead of None)#2736

Merged
smuzaffar merged 1 commit into
masterfrom
fix-empty-prev_t
May 5, 2026
Merged

Old bot: fix parsing of test command (use empty-string instead of None)#2736
smuzaffar merged 1 commit into
masterfrom
fix-empty-prev_t

Conversation

@iarspider
Copy link
Copy Markdown
Contributor

  • Command: test full cmssw
  • Exception:
Traceback (most recent call last):
  File "/data/sdt/cms-bot/process-pull-request.py", line 102, in <module>
    process_pr(repo_config, gh, repo, repo.get_issue(prId), opts.dryRun, force=opts.force)
  File "/data/sdt/cms-bot/process_pr.py", line 1882, in process_pr
    ok, v2, v3, v4, v5 = check_test_cmd(first_line, repository, global_test_params)
  File "/data/sdt/cms-bot/process_pr.py", line 888, in check_test_cmd
    res = parse_test_cmd(first_line)
  File "/data/sdt/cms-bot/process_pr.py", line 859, in parse_test_cmd
    if p.prev_keyword and not p.prev_keyword.fullmatch(prev_t):
TypeError: expected string or bytes-like object

Will forward-port to new bot.

@iarspider
Copy link
Copy Markdown
Contributor Author

@raoatifshad thanks for catching this!

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 5, 2026

A new Pull Request was created by @iarspider for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 5, 2026

cms-bot internal usage

iarspider added a commit that referenced this pull request May 5, 2026
@iarspider
Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 5, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7247f/53088/summary.html
COMMIT: abe6285
CMSSW: CMSSW_17_0_X_2026-05-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2736/53088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187168
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187135
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 3c947b1 into master May 5, 2026
15 checks passed
@smuzaffar
Copy link
Copy Markdown
Contributor

+externals

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 5, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the fix-empty-prev_t branch May 5, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants