Skip to content

Build C++ interface for torch extensions#10517

Merged
smuzaffar merged 2 commits into
IB/CMSSW_17_0_X/masterfrom
torch-extensions-cpp-interface
May 3, 2026
Merged

Build C++ interface for torch extensions#10517
smuzaffar merged 2 commits into
IB/CMSSW_17_0_X/masterfrom
torch-extensions-cpp-interface

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

Enable C++ interface for torch extension packages ( i.e. torch-scatter, torch-cluster and torch-sparse).

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 29, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10517 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar
Copy link
Copy Markdown
Contributor Author

enable gpu

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

1 similar comment
@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10517 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d04e0/52963/summary.html
COMMIT: 68bf3b3
CMSSW: CMSSW_17_0_X_2026-04-29-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10517/52963/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar smuzaffar force-pushed the torch-extensions-cpp-interface branch from 68bf3b3 to 1cccce2 Compare April 30, 2026 09:17
@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10517 was updated.

@smuzaffar smuzaffar force-pushed the torch-extensions-cpp-interface branch from 1cccce2 to 6138496 Compare May 1, 2026 10:32
@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test with #10493

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 1, 2026

Pull request #10517 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 2, 2026

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d04e0/52993/summary.html
COMMIT: 6138496
CMSSW: CMSSW_17_0_X_2026-05-01-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10517/52993/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
  • 2025.00000022025.0000002_RunZeroBias2025B_10k/step2_RunZeroBias2025B_10k.log
  • 9.09.0_Higgs200ChargedTaus/step1_Higgs200ChargedTaus.log
Expand to see more relval errors ...

AMD_MI300X Comparison Summary

Summary:

AMD_W7900 Comparison Summary

Summary:

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test with #10493

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 3, 2026

-1

Failed Tests: RelVals-AMD_MI300X
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d04e0/53016/summary.html
COMMIT: 6138496
CMSSW: CMSSW_17_0_X_2026-05-01-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10517/53016/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals-AMD_MI300X

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187168
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187136
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

AMD_W7900 Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

NVIDIA_L40S Comparison Summary

Summary:

@smuzaffar
Copy link
Copy Markdown
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 4484259 into IB/CMSSW_17_0_X/master May 3, 2026
19 of 20 checks passed
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 3, 2026

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants