Skip to content

Improved xml toolfile and automatically add the tool name, version and install path#10518

Merged
smuzaffar merged 3 commits into
IB/CMSSW_17_0_X/masterfrom
xml-tools-auto-path
Apr 30, 2026
Merged

Improved xml toolfile and automatically add the tool name, version and install path#10518
smuzaffar merged 3 commits into
IB/CMSSW_17_0_X/masterfrom
xml-tools-auto-path

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

@smuzaffar smuzaffar commented Apr 29, 2026

This cleans up the scram toolfile definition. No more @TOOL_BASE@ or @TOOL_ROOT@ in tool files. when these toolfiles are generated then now we add < tool path="%i"...> which then scram can use to set the UpperCaseTool_BASE (mostly used by cmssw build rules) and $TOOL_BASE. We now can use $TOOL_BASE within the toolfile to refer to the installation path of the tool

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 29, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10518 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e2cd3/52938/summary.html
COMMIT: cec8088
CMSSW: CMSSW_17_0_X_2026-04-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10518/52938/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10518 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e2cd3/52952/summary.html
COMMIT: 01ceb82
CMSSW: CMSSW_17_0_X_2026-04-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10518/52952/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 170 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4186963
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4186918
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

@smuzaffar
Copy link
Copy Markdown
Contributor Author

enable gpu

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar
Copy link
Copy Markdown
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 24aa4ec into IB/CMSSW_17_0_X/master Apr 30, 2026
19 of 20 checks passed
@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants