[ROOT628] Updated root to tip of branch v6-28-00-patches

[smuzaffar]

No description provided.

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/root628.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9abe/34621/summary.html
COMMIT: 0b8bed2
CMSSW: CMSSW_13_3_ROOT628_X_2023-09-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8684/34621/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestFWCoreServicesDriver_resource had ERRORS

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153392
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[smuzaffar]

ping

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9abe/34635/summary.html
COMMIT: 0b8bed2
CMSSW: CMSSW_13_3_ROOT628_X_2023-09-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8684/34635/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestFWCoreServicesDriver_resource had ERRORS

Comparison Summary

Summary:

• You potentially removed 10 lines from the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 3159
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150233
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9abe/34654/summary.html
COMMIT: 0b8bed2
CMSSW: CMSSW_13_3_ROOT628_X_2023-09-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8684/34654/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @nikodemas update monit tools version #8682

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9abe/34654/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9abe/34654/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestFWCoreServicesDriver_resource had ERRORS

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 344 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 125
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153267
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@makortel @Dr15Jones , while testing ROOT 6.28 changes we now see this FW unit tests failing [a]. Looks like with new changes of root now CMS requires at least 150MB more virtual memory. Do you see any obvious change in root which might have contributed to this increase?

@hahnjo, could it be due to root-project/root@8735554 llvm module path change?

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9abe/34654/unitTests/src/FWCore/Services/test/TestFWCoreServicesDriver_resource/testing.log

===== Test "TestFWCoreServicesDriver_resource" ====
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 08-Sep-2023 03:14:28.793 CEST
----- Begin Fatal Exception 08-Sep-2023 03:14:28 CEST-----------------------
An exception of category 'ExceededResourceVSize' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
Exceeded maximum allowed VSize of 1 GB (VSize is 1.15728)
----- End Fatal Exception -------------------------------------------------
Failure using /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT628_X_2023-09-06-2300/src/FWCore/Services/test/test_resource_succeed_cfg.py: status 94

---> test TestFWCoreServicesDriver_resource had ERRORS

[smuzaffar]

With existing root 6.28 i.e. commit 4376f61 cmsRun shows Vsize 0.676969G

[smuzaffar]

I tried reverting root-project/root@8735554 but still cmsRun process complains about high vsize, so root-project/root@8735554 is not the causing this

[smuzaffar]

#8689 shows that just rebuilding root (without any other update anyway shows high vsize). Let get this in and see if in IBs we do get this unit test failure

[hahnjo]

@hahnjo, could it be due to root-project/root@8735554 llvm module path change?

Hi @smuzaffar, that commit is only about CMake modules used during configuration time, not even during build itself. It does not affect memory usage while running ROOT, ie nothing to do with (runtime) C++ modules.