Skip to content

Conversation

@JanGerritSchulz
Copy link
Contributor

PR description:

This PR upgrades the existing class of SimDoublets to a more extensive class of SimPixelTracks. This allows for a more detailed analysis of the Patatrack pixel tracking performance by providing additional simulation truth for more intermediate objects in Patatrack. This includes triplets and N-tuplets and their respective cuts applied when built in reconstruction.

This PR is currently a draft and not ready for review. More detailed information will follow...

PR validation:

To be added...

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport and there is no backport planned.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49194/46499

@mmusich
Copy link
Contributor

mmusich commented Oct 21, 2025

type ngt

@mmusich
Copy link
Contributor

mmusich commented Oct 21, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency ClangBuild
Size: This PR adds an extra 492KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-976c7a/48750/summary.html
COMMIT: e61ed21
CMSSW: CMSSW_16_0_X_2025-10-20-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49194/48750/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49194/46501

@cmsbuild
Copy link
Contributor

Pull request #49194 was updated.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49194/47169

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants