Pixel CPE Generic-only era modifier by mroguljic · Pull Request #50480 · cms-sw/cmssw

mroguljic · 2026-03-20T11:00:20Z

PR description:

This PR adds a modifier to the Run 3 2026 era configuration that makes the PixelRecHits ESProducers use Generic CPE. The PR is created in case of a possible change in reconstruction during 2026 data-taking.

PR validation:

Tested at configuration level with

cmsDriver.py step3 --era Run3_2026 --conditions auto:run3_data --data -s RECO --no_exec -n 1 --python_filename test_Run3_SiPixelGenericCPE_2026.py
edmConfigDump test_Run3_SiPixelGenericCPE_2026.py >& alternative.txt

The full configuration, w.r.t. the unmodified configuration, only differs in the PixelCPE parameter for the two TkTransientTrackingRecHitBuilderESProducer for

src$ diff alternative.txt central.txt 
85755c85755
<     PixelCPE = cms.string('PixelCPEGeneric'),
---
>     PixelCPE = cms.string('PixelCPEClusterRepair'),
85766c85766
<     PixelCPE = cms.string('PixelCPEGeneric'),
---
>     PixelCPE = cms.string('PixelCPEClusterRepairWithoutProbQ'),

The producers, with the change included, are shown below

process.TTRHBuilderAngleAndTemplate = cms.ESProducer("TkTransientTrackingRecHitBuilderESProducer",
    ComponentName = cms.string('WithAngleAndTemplate'),
    ComputeCoarseLocalPositionFromDisk = cms.bool(False),
    Matcher = cms.string('StandardMatcher'),
    Phase2StripCPE = cms.string(''),
    PixelCPE = cms.string('PixelCPEGeneric'),
    StripCPE = cms.string('StripCPEfromTrackAngle'),
    appendToDataLabel = cms.string('')
)


process.TTRHBuilderAngleAndTemplateWithoutProbQ = cms.ESProducer("TkTransientTrackingRecHitBuilderESProducer",
    ComponentName = cms.string('WithAngleAndTemplateWithoutProbQ'),
    ComputeCoarseLocalPositionFromDisk = cms.bool(False),
    Matcher = cms.string('StandardMatcher'),
    Phase2StripCPE = cms.string(''),
    PixelCPE = cms.string('PixelCPEGeneric'),
    StripCPE = cms.string('StripCPEfromTrackAngle'),
    appendToDataLabel = cms.string('')
)

Changes are expected in all workflows that use Run3 2026 era modifier.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 16.0.X

cmsbuild · 2026-03-20T11:00:41Z

cms-bot internal usage

cmsbuild · 2026-03-20T11:01:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50480/48628

cmsbuild · 2026-03-20T11:02:06Z

A new Pull Request was created by @mroguljic for master.

It involves the following packages:

Configuration/Eras (operations)
RecoLocalTracker/SiPixelRecHits (reconstruction)

@Moanwar, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dkotlins, @elusian, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @makortel, @mmasciov, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2026-03-20T11:03:33Z

I guess for testing purposes it would be good to start adding

Run3_2026 = cms.ModifierChain(Run3_2025, run3_SiPixelGenericCPE)

to the configuration, assuming that's the intended outcome.

cmsbuild · 2026-03-20T12:16:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50480/48631

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run3_2026_cff.py modified in PR(s): L1S(Nano): add CaloTowers to 2026 "L1ScoutingNano" workflows #50374

cmsbuild · 2026-03-20T12:16:11Z

Pull request #50480 was updated. @Moanwar, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

makortel · 2026-03-20T13:56:50Z

RecoLocalTracker/SiPixelRecHits/python/PixelCPEESProducers_cff.py

+# Customize the Pixel CPE to only use Generic algorithm
+from Configuration.Eras.Modifier_run3_SiPixelGenericCPE_cff import run3_SiPixelGenericCPE
+from RecoTracker.Configuration.customizePixelCPEGenericOnly import replacePixelCPETemplateWithGeneric
+modifyForRun3SiPixelGenericCPE_ = run3_SiPixelGenericCPE.makeProcessModifier(replacePixelCPETemplateWithGeneric)


One detail to be aware of. The modifyForRun3SiPixelGenericCPE_ will be called once during the first process.load() call that loads a configuration fragment whose import chain leads to this cff file. If a second process.load() call loads a configuration fragment (same or different) whose import chain also leads to this cff file, the modifyForRun3SiPixelGenericCPE_ will not be called again.

Given how the ConfigBuilder works and how the application configuration fragments are organized, this probably works for reconstruction. But if this fragment gets loaded via e.g. DQM, Validation, AlCa configuration fragments, and if those fragments add any new modules that have configuration parameters for the CPE, those configuration parameters are not modified.

Thanks for the very relevant warning. We will attempt a different implementation that does not use makeProcessModifier.

There is already an appropriate modifier in CMSSW. It was intended for Phase-2 workflows, but it works for Phase-1 as well.

After changing the era,

from Configuration.ProcessModifiers.PixelCPEGeneric_cff import PixelCPEGeneric Run3_2026 = cms.ModifierChain(Run3_2025, PixelCPEGeneric)

the config differs only in the ESProducers for RecHits

src$ diff alternative.txt central.txt 85755c85755 < PixelCPE = cms.string('PixelCPEGeneric'), --- > PixelCPE = cms.string('PixelCPEClusterRepair'), 85766c85766 < PixelCPE = cms.string('PixelCPEGeneric'), --- > PixelCPE = cms.string('PixelCPEClusterRepairWithoutProbQ'),

cmsbuild · 2026-03-23T10:47:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50480/48655

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run3_2026_cff.py modified in PR(s): L1S(Nano): add CaloTowers to 2026 "L1ScoutingNano" workflows #50374

cmsbuild · 2026-03-23T10:47:21Z

Pull request #50480 was updated. @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please check and sign again.

vlimant · 2026-03-23T10:53:47Z

assign ppd

cmsbuild · 2026-03-23T10:54:05Z

New categories assigned: ppd

@abenecke,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich · 2026-03-23T11:12:28Z

please test

cmsbuild · 2026-03-23T14:53:22Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-608934/52147/summary.html
COMMIT: 566ca3c
CMSSW: CMSSW_16_1_X_2026-03-22-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50480/52147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 4205 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4185284
DQMHistoTests: Total failures: 3413
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4181851
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

vlimant · 2026-03-23T15:12:01Z

+1

cmsbuild · 2026-03-23T15:12:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

vlimant · 2026-03-23T15:12:31Z

let's have the 16.0 backport created right away please

ftenchini · 2026-03-23T15:56:55Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Mar 20, 2026

cmsbuild added reconstruction-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Mar 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2026

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2026

makortel reviewed Mar 20, 2026

View reviewed changes

add Generic CPE modifier to 2026 era

566ca3c

mroguljic force-pushed the 2026_CPEGeneric_modifier branch from d1236a0 to 566ca3c Compare March 23, 2026 10:44

cmsbuild added code-checks-pending and removed reconstruction-pending code-checks-approved trk labels Mar 23, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 23, 2026

cmsbuild added the ppd-pending label Mar 23, 2026

cmsbuild added tests-started and removed tests-pending labels Mar 23, 2026

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Mar 23, 2026

cmsbuild added fully-signed ppd-approved and removed pending-signatures ppd-pending labels Mar 23, 2026

mroguljic mentioned this pull request Mar 23, 2026

[16.0.X] Pixel CPE Generic-only era modifier #50497

Merged

cmsbuild added orp-approved and removed orp-pending labels Mar 23, 2026

cmsbuild merged commit 6e97e5f into cms-sw:master Mar 23, 2026
10 checks passed

Conversation

mroguljic commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

mmusich commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

makortel Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

mroguljic Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

mroguljic Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Mar 23, 2026

Uh oh!

cmsbuild commented Mar 23, 2026

Uh oh!

vlimant commented Mar 23, 2026

Uh oh!

cmsbuild commented Mar 23, 2026

Uh oh!

mmusich commented Mar 23, 2026

Uh oh!

cmsbuild commented Mar 23, 2026

Comparison Summary

Uh oh!

vlimant commented Mar 23, 2026

Uh oh!

cmsbuild commented Mar 23, 2026

Uh oh!

vlimant commented Mar 23, 2026

Uh oh!

ftenchini commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mroguljic commented Mar 20, 2026 •

edited

Loading

cmsbuild commented Mar 20, 2026 •

edited

Loading