Cling template ids #207
Closed
Cling template ids #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix zooming on haxis
This is very special feature, which has no equivalent in web display
This has the advantage that the offsets to all other chunks, that are logically located afterwards, are already known and can be written immediately instead of seeking back and patching them afterwards. The only downside is that the seek operation from the first to the second chunk during reading may be slightly more expensive because it is now backwards in the file, across the entire split blob. As a result of this change, RNTupleFileWriter in all cases writes into monotonically increasing offets, which simplifies further changes related to the support of Direct I/O.
This has the advantage that we can precisely control the alignment, which is important to support Direct I/O.
RNTupleFileWriter::RFileSimple does its own buffering now.
This allows more fine-grained control over the flags passed to the system call, which will be required to enable Direct I/O.
Direct I/O bypasses the OS page cache and allows to reach much higher bandwidths. However, it introduces strict alignment requirements to the offset and size of all write requests, as well as the userspace pointer.
Renames fColumns to fAvailableColumns, which keeps the promised invariant of storing columns in order of representation index and column index. Instead of swapping owned columns when the column representation changes during write (RFieldRepresentationModifier), we now instead just move the fPrincipalColumn non-owning pointer. To accomodate for fields with two columns per representation (string, unsplit), we add a non-owning fAuxiliaryColumn that works accordingly to fPrincipalColumn.
Upstream Clang keeps TemplateIdAnnotations around "if they might still be in the token stream." See upstream commit for more details: llvm/llvm-project@6163aa9 (included in Clang 11, in ROOT since the upgrade to LLVM 13) This reasoning doesn't apply when we fully reset the Parser state in ParserStateRAII's destructor, and we expect the swapped out vector of TemplateIdAnnotations to be empty in order to not leak. Fixes root-project#16121
Author
|
please test for CMSSW_14_1_ROOT6_X/el8_amd64_gcc12 |
|
A new Pull Request was created by @smuzaffar for branch cms/master/d774a42d19. @aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0423/40718/summary.html Comparison SummarySummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.