Skip to content

Close 164 and 165#166

Merged
dvanhorn merged 4 commits intomainfrom
fix-164-165
Feb 12, 2024
Merged

Close 164 and 165#166
dvanhorn merged 4 commits intomainfrom
fix-164-165

Conversation

@pdarragh
Copy link
Copy Markdown
Contributor

@pdarragh pdarragh commented Feb 9, 2024

Adds instructions:

  • Jz
  • Jnz
  • Cmovz
  • Cmovnz
  • Shl
  • Shr

Updates documentation accordingly.

Documentation also extended to explain the FLAGS register more explicitly, and instructions that modify the flags are explicitly annotated.

Docs now include a section about conditional flags. Closes #165.
@pdarragh
Copy link
Copy Markdown
Contributor Author

pdarragh commented Feb 9, 2024

I added the -z-suffixed instructions because (a) I already support them in cmsc430/a86-interpreter, but (b) I think it helps when the other three supported instructions share a name with their flags already. Then we can just say the -e suffix is an alias for -z, which makes sense when Cmp is used due to the nature of subtraction.

@pdarragh pdarragh requested a review from dvanhorn February 9, 2024 20:23
@dvanhorn dvanhorn merged commit 3bf4889 into main Feb 12, 2024
@pdarragh pdarragh deleted the fix-164-165 branch February 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants