stops any weird audio player crashes #8875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Mar 26, 2025
Contributor
Drulikar
left a comment
Drulikar
left a comment
There was a problem hiding this comment.
Dunno if this would fix their issue but doesn't hurt.
github-project-automation
bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
Member
Author
not the underlying cause, but the bluescreen is caused by an uncaught error within this promise, which we're catching now |
github-merge-queue bot
pushed a commit
to Aurorastation/Aurora.3
that referenced
this pull request
Mar 26, 2025
this is a bit of cmss13-devs/cmss13#8646 cmss13-devs/cmss13#8875 cmss13-devs/cmss13#8606 cmss13-devs/cmss13#8607 cmss13-devs/cmss13#8359 cmss13-devs/cmss13#7860 ( and thus ParadiseSS13/Paradise#25105 ParadiseSS13/Paradise#25205 ParadiseSS13/Paradise#25363 ParadiseSS13/Paradise#26423 and ParadiseSS13/Paradise#26433 ) tgstation/tgstation#89766 in order to work properly - using the efficient storage method, instead of the byond json method - github pages needs to be enabled and built from the gh-pages branch. because yeah --------- Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Mar 27, 2025
Absolucy
added a commit
to Monkestation/Monkestation2.0
that referenced
this pull request
Mar 27, 2025
## About The Pull Request im just throwing a bunch of bugfixes, cleanups, maybe some minor stuff into this PR, bc I'm too lazy to split things up. dw i'll actually do the changelog <img alt="cat-like typing detected" src="https://github.com/user-attachments/assets/cfb61ff8-c0b9-4889-9563-9bb2fe6c35aa" width="50%"> **Ports**: - BeeStation/BeeStation-Hornet#12240 (the color picker fix specifically) - tgstation/tgstation#74884 - tgstation/tgstation#78984 - tgstation/tgstation#80521 - tgstation/tgstation#81433 - tgstation/tgstation#83329 - tgstation/tgstation#83427 - tgstation/tgstation#85302 - tgstation/tgstation#86339 - tgstation/tgstation#86959 - tgstation/tgstation#88791 - tgstation/tgstation#89110 - tgstation/tgstation#89164 - tgstation/tgstation#89374 - tgstation/tgstation#89802 - tgstation/tgstation#89885 - tgstation/tgstation#90005 - tgstation/tgstation#90045 - tgstation/tgstation#90140 - tgstation/tgstation#90154 - tgstation/tgstation#90207 - tgstation/tgstation#90215 - tgstation/tgstation#90227 (which is actually a partial port of _this PR_ but whatever) - tgstation/tgstation#90256 - cmss13-devs/cmss13#8674 - cmss13-devs/cmss13#8712 - cmss13-devs/cmss13#8875 Fixes #5837 Fixes #5872 Fixes #6010 Fixes #6049 Fixes #6061 (probably) Fixes #6067 some bugfixes, some ports ## Changelog :cl: fix: Toxins no longer damage your liver if you are immune to toxins anyways. fix: Fixed an edge-case where, if two heretics of different paths applied a mark to the same person, the effects from the first mark (i.e moon path's pacifism) would likely be permanent. code: Slightly improved the code for the Cortex Imprint bioware. fix: Fixed an centcom ghost player escape exploit. fix: You will now be ejected from any jaunt (i.e bloodcrawl or shadow walk) if you lose consciousness somehow during the jaunt. fix: The _ispath SDQL2/Lua wrapper can now be used to actually check if something is a path. code: Added the _is_type_in_typecache wrapper, for SDQL2 / Lua scripts. fix: Probably fixed techfab/lathe/mechfab UIs not updating sometimes. fix: The animation from a xeno chestbursting out of someone is now properly removed after they burst out. fix: You now must observe or join the game in order to buy or open a lootbox, to prevent any potential issues or confusion where you pay for a lootbox but don't get it. qol: The Good Assistants Point redeemer thingy can no longer be used to spam messages or loud sounds. fix: (itsmeow) The tgui color picker is colorful again on BYOND 516. qol: (SmArtKar) If you have auto fit viewport enabled, it will trigger upon entering or exiting fullscreen. add: (jlsnow301) TGUI icons are updated to latest FontAwesome version, v6.7.2. fix: (TiviPlus) fixed a case that could make untoggling fullscreen make your window small. code: (TiviPlus) Cleaned up some fullscreen and status bar toggle code to function better. fix: (Holoo-1) Fixed white space when observing in auto observe mode refactor: (Kylerace) Tech disk uploading isnt super slow anymore (much harder to crash spacetime with it) code: (SmArtKar) Removed the 516 beta warning entirely. fix: (hry-gh) tgui windows closing should no longer cause sticky keys, especially on BYOND 516. fix: (hry-gh) The audio player shouldn't blow up in weird circumstances anymore. /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: Holoo <38228316+Holoo-1@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Penelope Haze <out.of.p.haze@proton.me> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com> Co-authored-by: MichiRecRoom <1008889+LikeLakers2@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: hack-wrench <60922927+hack-wrench@users.noreply.github.com>
github-project-automation
bot
moved this from Partially Approved / Mergeable
to Merged
in Review Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
fix: the audio player shouldn't blow up in weird circumstances
/:cl: