Merged
Conversation
cmttt
force-pushed
the
ls/fix-bq-sink-publisher
branch
2 times, most recently
from
424edcf to
a678938
Compare
…ow sink New AsyncPubSubPublisher: - asyncio.Queue buffer with background flush task - Batches up to 250 messages or flushes after 1s - Flush runs sync publishes in run_in_executor - Graceful shutdown flushes remaining messages - No threading locks, no gevent, no background threads Removed BQ shadow sink from osprey — it imports from discord_smite and belongs in the Discord repo (discord_smite/osprey_async_plugins).
cmttt
force-pushed
the
ls/fix-bq-sink-publisher
branch
from
a678938 to
5543e07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchPubsubPublisherClient has a class-level threading.Lock that causes 'cannot release un-acquired lock' when released from a background callback thread. Replace with direct PublisherClient (batch_size=1, no background threads). Also removes dependency on osprey.worker.lib.publisher.