Skip to content

Conversation

@AlSchlo
Copy link
Collaborator

@AlSchlo AlSchlo commented May 20, 2025

  1. Does not handle costing.
  2. Fixes memo regression.
  3. Extend DSL support of stored plans.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

Attention: Patch coverage is 89.53488% with 117 lines in your changes missing coverage. Please review.

Project coverage is 90.2%. Comparing base (c452468) to head (30e571e).

Files with missing lines Patch % Lines
optd/src/optimizer/merge/helpers.rs 76.6% 32 Missing ⚠️
optd/src/optimizer/hir_cir/from_cir.rs 48.6% 19 Missing ⚠️
optd/src/optimizer/tasks/delete.rs 33.3% 14 Missing ⚠️
optd/src/memo/memory/helpers.rs 94.2% 12 Missing ⚠️
optd/src/optimizer/handlers.rs 50.0% 12 Missing ⚠️
optd-cli/src/main.rs 0.0% 6 Missing ⚠️
optd/src/optimizer/tasks/launch.rs 93.5% 6 Missing ⚠️
optd/src/dsl/analyzer/from_ast/converter.rs 33.3% 4 Missing ⚠️
optd/src/demo/mod.rs 91.8% 3 Missing ⚠️
optd/src/dsl/analyzer/hir/mod.rs 57.1% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
Files with missing lines Coverage Δ
optd/src/dsl/engine/eval/expr.rs 98.3% <100.0%> (+<0.1%) ⬆️
optd/src/dsl/engine/eval/match.rs 99.3% <100.0%> (+<0.1%) ⬆️
optd/src/optimizer/jobs/manage.rs 100.0% <100.0%> (+17.3%) ⬆️
optd/src/optimizer/memo_io/ingest.rs 84.8% <ø> (+31.9%) ⬆️
optd/src/optimizer/mod.rs 98.3% <100.0%> (+6.7%) ⬆️
optd/src/optimizer/tasks/manage.rs 85.4% <ø> (+34.6%) ⬆️
optd/src/memo/memory/materialize.rs 97.6% <98.2%> (+13.2%) ⬆️
optd/src/optimizer/jobs/execute.rs 99.3% <92.3%> (+39.2%) ⬆️
optd/src/optimizer/merge/mod.rs 96.7% <97.5%> (+0.3%) ⬆️
optd/src/demo/mod.rs 90.2% <91.8%> (-0.2%) ⬇️
... and 10 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlSchlo AlSchlo merged commit e6d34dc into main May 22, 2025
12 checks passed
@AlSchlo AlSchlo deleted the alexis/optimizer-logical-to-physical branch May 22, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants