Skip to content

[fb-package] Fix failing contingency CI due to readr version change #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krivard merged 4 commits into from
Jul 21, 2021
Merged

[fb-package] Fix failing contingency CI due to readr version change #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7dcded
replace deprecated arg in write_csv
nmdefries Jul 20, 2021
4ba5467
prevent readr from being updated
nmdefries Jul 20, 2021
8734663
remove empty test file
nmdefries Jul 20, 2021
d2eb278
explicitly install desired readr version if missing
nmdefries Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/r-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,14 @@ jobs:
${{ runner.os }}-r-facebook-survey-
- name: Install R dependencies
run: |
if ( packageVersion("readr") != "1.4.0" ) {
install.packages("devtools")
devtools::install_version("readr", version = "1.4.0")
}
install.packages("remotes")
remotes::update_packages(c("rcmdcheck", "mockr"), upgrade="always")
dependency_list <- remotes::dev_package_deps(dependencies=TRUE)
remotes::update_packages(dependency_list$package, upgrade="always")
remotes::update_packages(dependency_list$package[dependency_list$package != "readr"], upgrade="always")
shell: Rscript {0}
- name: Check
run: |
Expand Down
2 changes: 1 addition & 1 deletion facebook/delphiFacebook/unit-tests/testthat/test-contingency-utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ test_that("testing get_filenames_in_range command", {

create_dir_not_exist(tdir)
for (filename in files) {
write_csv(data.frame(), path = file.path(tdir, filename))
write_csv(data.frame(), file.path(tdir, filename))
}

params <- list(
Expand Down
4 changes: 0 additions & 4 deletions facebook/delphiFacebook/unit-tests/testthat/test-contingency-variables.R
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion facebook/delphiFacebook/unit-tests/testthat/test-utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test_that("testing create dir function", {

test_that("testing read params when missing file", {

# expect error if missing file, since no template in test dir
# expect error if missing file, since no template in test dir
tdir <- tempfile()
expect_warning(expect_error(read_params(tdir)))
})
Expand Down