Skip to content

Conversation

@nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Oct 6, 2021

Description

For survey pipeline purposes, readr was pinned to version 1.4.0 due to breaking changes in readr 2.0.0 (#1129). A few updates to readr have been made since then, so let's try again.

Changelog

  • Remove version requirement in DESCRIPTION (added in Create dockerfile for survey pipeline #1244).
  • Remove version-checking and explicit install of readr in survey test workflow.
  • Remove readr version pinning in Dockerfile.

@nmdefries nmdefries requested a review from korlaxxalrok October 6, 2021 20:48
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nmdefries
Copy link
Contributor Author

nmdefries commented Oct 11, 2021

Although tests pass, the new version of readr seems to produce different output than the old version; investigating.

Ah false alarm, I was comparing against a branch that had another survey change added; more careful choice of comparison branch yields the same output.

@nmdefries nmdefries marked this pull request as draft October 11, 2021 16:35
@nmdefries nmdefries marked this pull request as ready for review October 11, 2021 17:26
@korlaxxalrok korlaxxalrok merged commit bcdbcdd into main Oct 11, 2021
@korlaxxalrok korlaxxalrok deleted the remove-readr-version-requirement branch October 11, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants