Change outlier checks as warnings #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
reviewed
Oct 20, 2021
Contributor
nmdefries
left a comment
nmdefries
left a comment
There was a problem hiding this comment.
Waiting on comment clarifying how excessive warning thresholds were set, otherwise looks good.
nmdefries
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also create summary report if too many warnings are created.
Description
Outlier checks remain too sensitive after tuning. We make these warnings instead, and aim to alert slack if too many warnings pop up (rather than have too many false positives)
Changelog
Itemize code/test/documentation changes and files added/removed.