Skip to content

Remove artificial day shift in labeling #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Remove artificial day shift in labeling #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8acd892
remove artificial day shift in labeling
mariajahja Dec 11, 2021
5c3be68
update tests to expect no date shift
mariajahja Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions claims_hosp/delphi_claims_hosp/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

Author: Maria Jahja
Created: 2020-06-01
Modified: 2020-09-27
Modified: 2021-12-11
Copy link
Contributor

@chinandrew chinandrew Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we're not relying on git to track this?

Copy link
Contributor

@krivard krivard Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible reason: production deployments are stripped of all .git metadata, so markup like this would be the only way to verify which changes are in effect. It's not a good reason (perennially backburnered is having deployment add a VERSION file with the gitref, which would be better) but it's better than nothing


"""

Expand All @@ -26,8 +26,8 @@ class Config:
# (one day needed for smoother to produce values)
BURN_IN_PERIOD = timedelta(days=1)

# shift dates forward for labeling purposes
DAY_SHIFT = timedelta(days=1)
# if desired, shift dates forward for labeling purposes
DAY_SHIFT = timedelta(days=0)

# data columns
CLAIMS_COUNT_COLS = ["Denominator", "Covid_like"]
Expand Down
8 changes: 4 additions & 4 deletions claims_hosp/tests/test_update_indicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def test_write_to_csv_results(self):
updater.write_to_csv(res0, td.name)

# check outputs
expected_name = f"20200502_geography_{Config.signal_name}.csv"
expected_name = f"20200501_geography_{Config.signal_name}.csv"
assert exists(join(td.name, expected_name))
output_data = pd.read_csv(join(td.name, expected_name))
assert (
Expand All @@ -155,7 +155,7 @@ def test_write_to_csv_results(self):
assert np.isnan(output_data.direction.values).all()
assert np.isnan(output_data.sample_size.values).all()

expected_name = f"20200503_geography_{Config.signal_name}.csv"
expected_name = f"20200502_geography_{Config.signal_name}.csv"
assert exists(join(td.name, expected_name))
output_data = pd.read_csv(join(td.name, expected_name))
assert (
Expand All @@ -167,7 +167,7 @@ def test_write_to_csv_results(self):
assert np.isnan(output_data.direction.values).all()
assert np.isnan(output_data.sample_size.values).all()

expected_name = f"20200505_geography_{Config.signal_name}.csv"
expected_name = f"20200504_geography_{Config.signal_name}.csv"
assert exists(join(td.name, expected_name))
output_data = pd.read_csv(join(td.name, expected_name))
assert (
Expand Down Expand Up @@ -221,7 +221,7 @@ def test_write_to_csv_with_se_results(self):
updater.write_to_csv(res0, td.name)

# check outputs
expected_name = f"20200502_geography_{signal_name}.csv"
expected_name = f"20200501_geography_{signal_name}.csv"
assert exists(join(td.name, expected_name))
output_data = pd.read_csv(join(td.name, expected_name))
assert (
Expand Down